Repository navigation
Scope hydration goto labels - #95
Merged
WyriHaximus merged 1 commit intoOct 16, 2026
Merged
Conversation
WyriHaximus
force-pushed
the
scope-hydration-gotos
branch
from
October 16, 2026 13:32
b22121a to
9207660
Compare
When generating an object mapper, it uses the property name with a prefix as the goto label. If there are, however, multiple objects code is generated for with the same mame, they will cause a fatal error: ``` Fatal error: Label 'after_identifier' already defined ``` This changeset suffixes it with the full class name to keep it unique.
WyriHaximus
force-pushed
the
scope-hydration-gotos
branch
from
October 16, 2026 13:46
9207660 to
43f97b6
Compare
frankdejonge
approved these changes
Oct 16, 2026
Member
|
@WyriHaximus sounds logical, fix looks right to me! |
Collaborator
Author
|
Ok awesome, do you prefer to give this fix a patch release on it's own. Or group it with other outstanding work to release? |
Member
|
@WyriHaximus fine to release with the rest, have at it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating an object mapper, it uses the property name with a prefix as the goto label. If there are, however, multiple objects code is generated for with the same mame, they will cause a fatal error:
This changeset suffixes it with the full class name to keep it unique.