fix: handle 202 Accepted response in demo store method#211
Open
haifengqiu wants to merge 1 commit intoEverMind-AI:mainfrom
Open
fix: handle 202 Accepted response in demo store method#211haifengqiu wants to merge 1 commit intoEverMind-AI:mainfrom
haifengqiu wants to merge 1 commit intoEverMind-AI:mainfrom
Conversation
When background mode is enabled (the default), the memorize endpoint returns HTTP 202 Accepted. The current code calls raise_for_status() then unconditionally parses the response as a v1 completion response, but a 202 response body lacks the expected "data.status" field, causing store() to report failure even though the request was accepted. Add an explicit 202 check after raise_for_status() to return success when the request has been queued for background processing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When background mode is enabled (the default), the memorize endpoint returns HTTP 202 Accepted. The current code calls raise_for_status() then unconditionally parses the response as a v1 completion response, but a 202 response body lacks the expected "data.status" field, causing store() to report failure even though the request was accepted.
Add an explicit 202 check after raise_for_status() to return success when the request has been queued for background processing.
Summary
Area
Verification
Checklist
.envfiles, dependency folders, or generated output.Notes for Reviewers
By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.