Refactor find wiki method

[AshakaE]

closes https://github.com/EveripediaNetwork/issues/issues/4624

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[gemini-code-assist]

Summary of Changes

Hello @AshakaE, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactor of the wiki data retrieval mechanism within the MarketCapService. The core findWikiBulk method has been overhauled to leverage raw SQL queries, moving away from TypeORM's ORM query builder. This change is intended to improve the performance and efficiency of fetching wiki-related data, particularly for bulk operations, and simplifies the overall data processing flow in getWikiData.

Highlights

• Refactored Wiki Data Retrieval: The findWikiBulk method has been renamed to findWikisBulk and completely rewritten to use raw SQL queries instead of TypeORM's createQueryBuilder. This change aims to optimize data fetching for wiki, linked wiki, and event information.
• Optimized Data Queries: The new implementation utilizes direct this.dataSource.query() calls, allowing for more precise and potentially faster data retrieval, especially for complex joins and conditions involving market_cap_ids, wiki metadata, and events.
• Streamlined getWikiData Method: The getWikiData method has been simplified by removing the batch processing loop. It now calls the refactored findWikisBulk method once for all IDs, improving code readability and reducing complexity.
• Dependency Cleanup: Unused imports such as Brackets, ILike, In from typeorm and HttpService from @nestjs/axios have been removed, contributing to a cleaner codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the wiki data fetching logic, replacing TypeORM's query builder with raw SQL queries for performance. While the parallel data fetching is a good optimization, the changes introduce several significant issues. My review focuses on a loss of type safety, a potential bug in cache TTL configuration, the removal of a crucial batching mechanism, and incorrect type definitions. Addressing these points will improve the code's robustness, maintainability, and correctness.