Skip to content

feat(export): manifest warnings for skipped resources#27

Merged
fmenesesg merged 1 commit into
mainfrom
feat/manifest-warnings
Jun 11, 2026
Merged

feat(export): manifest warnings for skipped resources#27
fmenesesg merged 1 commit into
mainfrom
feat/manifest-warnings

Conversation

@fmenesesg

Copy link
Copy Markdown
Collaborator

Proposed change

Record optional product sidecar fetch failures in manifest.json warnings[] instead of failing silently. Sets incomplete: true when warnings exist. Visualizer index renders an Export warnings section.

Type of change

  • New feature

RHCL checklist

  • Tests added or updated (go test ./... or mvn test / npm test)
  • CI does not introduce -DskipTests without justification
  • No secrets in diff (tokens, kubeconfigs, OIDC secrets)
  • rhcl-ai docs updated if export/import contract changes
  • PR description and docs in English
  • Tested in local lab if applicable (seed → export → analyze)

Test plan

  • TestExportRecordsWarningsOnSkippedSidecars — missing OIDC sidecar
  • TestManifestRecordSkip — warning helper
  • TestWriteReportManifestWarnings — index section
  • go test ./... — 119 tests; coverage 80.4%

Changes

File Change
internal/output/writer.go Warnings[], RecordSkip()
internal/export/exporter.go Record skip on optional GET failure
internal/visualize/report.go Export warnings section in index
*_test.go Coverage for warnings flow

Closes #26

Made with Cursor

Append warnings when optional product Admin API fetches fail, mark
export incomplete, and surface the list in the visualizer index.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fmenesesg fmenesesg requested a review from pcastelo as a code owner June 11, 2026 20:35
@fmenesesg fmenesesg added area/feature Feature request type:feature New feature or enhancement labels Jun 11, 2026
@fmenesesg fmenesesg merged commit 3ef55b0 into main Jun 11, 2026
1 check passed
@fmenesesg fmenesesg deleted the feat/manifest-warnings branch June 11, 2026 20:37
fmenesesg added a commit that referenced this pull request Jun 11, 2026
feat(export): manifest warnings for skipped resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/feature Feature request type:feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Export manifest warnings for skipped resources

1 participant