refactor(export): inject CommandRunner into toolbox#31
Merged
Conversation
Add CommandRunner interface with default exec implementation so native and container export paths are testable without real exec. Co-authored-by: Cursor <cursoragent@cursor.com>
fmenesesg
added
area/tests
fmenesesg
added a commit
that referenced
this pull request
Jun 11, 2026
…nd-runner refactor(export): inject CommandRunner into toolbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Inject
CommandRunnerintoToolboxfor testability (architecture review D1). Production code defaults toos/exec; tests use a mock to verify native/container command construction and error handling.Type of change
RHCL checklist
go test ./...ormvn test/npm test)-DskipTestswithout justificationTest plan
TestExportProductNativeUsesRunner— native binary + argsTestRunContainerArgs— podman run, cert mount, remote URLTestRunCommandEmptyOutput/TestRunCommandStderrErrorgo test ./...— 122 tests; coverage 81.9%Changes
internal/export/toolbox.goCommandRunnerinterface,execCommandRunner, inject via optionsinternal/export/toolbox_test.goCloses #30
Made with Cursor