feat(export): strict mode, layout verify, golden tests, revive#37
Merged
Conversation
Add --strict export flag (C2), VerifyExport for integration assertions (T12), golden layout test (T13), and enable revive in golangci-lint. Co-authored-by: Cursor <cursoragent@cursor.com>
fmenesesg
added
area/ci
This was referenced Jun 11, 2026
fmenesesg
added a commit
that referenced
this pull request
Jun 11, 2026
…ndle feat(export): strict mode, layout verify, golden tests, revive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bundle of architecture review follow-ups for export quality and static analysis.
Type of change
RHCL checklist
go test ./...ormvn test/npm test)-DskipTestswithout justificationC2 —
--strictErrStrictSidecar)threescale-export --strictT12 — Integration assertions
export.VerifyExport(root)validates manifest schema, counts, and required dirs/filesTestIntegrationExportcalls it after live exportT13 — Golden layout
TestExportGoldenLayoutcompares sorted export paths totestdata/golden-export-layout.txtRevive linter
Test plan
TestExportStrictFailsOnMissingSidecarTestVerifyExportLayout+TestExportGoldenLayout-tags=integration+ secrets)golangci-lint run ./...— cleango test ./...— 125 tests; coverage 81.3%Closes #36
Made with Cursor