fix: fetchChats e chat - Painel de mensagens no Manager

[moothz]

📋 Description

Modificação simples que previne erros de acesso à propriedades não definidas de objetos, que interrompem o fluxo do /chat/findChats e fazem com o que os chats no manager não sejam carregados.

Resolve esses erros:

• No manager, acessando os chats da instancia: 'The application is taking longer than expected to load, please try again in a few minutes.'
• /chat/findChats: Cannot read properties of null (reading 'mediaUrl')
• /chat/findChats: Cannot convert undefined or null to object

🔗 Related Issue

Closes #2058

🧪 Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🧹 Code cleanup
• 🔒 Security fix

🧪 Testing

• Manual testing completed
• Functionality verified in development environment
• No breaking changes introduced
• Tested with different connection types (if applicable)

✅ Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have manually tested my changes thoroughly
• I have verified the changes work with different scenarios
• Any dependent changes have been merged and published

Summary by Sourcery

Fix null and undefined property access in cleanMessageData to prevent chat loading failures

Bug Fixes:

• Prevent errors when accessing undefined message properties to ensure chats load correctly in the manager panel and /chat/findChats

Enhancements:

• Move mediaUrl extraction and base64 deletion inside a guard on cleanedMessage.message to avoid null property access

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the cleanMessageData method in ChannelStartupService by adding guards against undefined message objects and reorganizing the extraction, deletion, and restoration of mediaUrl and base64 properties to prevent runtime errors when loading chats in the manager.

Sequence diagram for cleanMessageData error prevention flow

sequenceDiagram
participant S as ChannelStartupService
participant M as Message
S->>M: Check if message exists
alt message is undefined/null
  S-->>S: Return message
else message exists
  S->>M: Extract mediaUrl
  S->>M: Delete base64
  S->>M: Clean imageMessage (if exists)
  S->>M: Clean documentWithCaptionMessage (if exists)
  S->>M: Restore mediaUrl (if exists)
end
S-->>S: Return cleanedMessage

Loading

Class diagram for updated ChannelStartupService.cleanMessageData method

classDiagram
class ChannelStartupService {
  +cleanMessageData(message: any): any
}
class Message {
  mediaUrl
  base64
  imageMessage
  documentWithCaptionMessage
}
ChannelStartupService --> Message : cleans
Message --> ImageMessage
Message --> DocumentWithCaptionMessage
class ImageMessage {
  url
}
class DocumentWithCaptionMessage {
  url
  name
}

Loading

File-Level Changes

Change	Details	Files
Refactor cleanMessageData to guard against undefined messages and reorganize mediaUrl/base64 handling	Add early return if message is falsy Wrap base64 deletion and mediaUrl extraction inside the message existence check Restore mediaUrl only when it was originally defined Remove redundant variable declarations and extra blank lines	src/api/services/channel.service.ts

Possibly linked issues

• [BUG]Erro 500 na listagem de Chats #2058: The PR fixes the 'Cannot read properties of null (reading 'mediaUrl')' error reported in the issue by handling cases where 'message' or 'mediaUrl' are null in cleanMessageData.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider defining a proper Message interface instead of using any to improve type safety and clarity in cleanMessageData.
• You could simplify the null-checks and property deletions using optional chaining (e.g., cleanedMessage.message?.base64) and object spread to make the code more concise.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining a proper Message interface instead of using `any` to improve type safety and clarity in cleanMessageData.
- You could simplify the null-checks and property deletions using optional chaining (e.g., `cleanedMessage.message?.base64`) and object spread to make the code more concise.

## Individual Comments

### Comment 1
<location> `src/api/services/channel.service.ts:586` </location>
<code_context>
       }
-    }

-    if (mediaUrl) cleanedMessage.message.mediaUrl = mediaUrl;
+      if (mediaUrl) cleanedMessage.message.mediaUrl = mediaUrl;
+    }
</code_context>

<issue_to_address>
**suggestion:** Reassigning mediaUrl may be redundant if it was not modified.

If mediaUrl remains unchanged during cleaning, this reassignment can be removed for clarity.

```suggestion
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Lucasbrunoferreira]

Alguma previsão de merge? Estou enfrentando esse problema

@DavidsonGomes

[Lucasbrunoferreira]

Hoje aconteceu novamente, e ao invés de recriar, eu busquei as últimas mensagens no banco de dados. Encontrei um registro na tabela Message, que não continha contéudo na coluna message, estava com status EDITED.
Ao excluir o registro, o endpoint /chat/findChats voltou a funcionar