fix: scope prepublishOnly's attw check to the node16 profile - #42
Merged
Merged
Conversation
attw --pack defaults to its own "strict" profile, which includes node10 (pre-exports-field) resolution, whereas tsdown's own build-time attw check already targets node16 explicitly. A single "." export happened to satisfy node10 resolution too, masking the mismatch, but a genuine multi-entry subpath export (cc-peer/alias-pool) cannot be resolved under node10 by design: legacy resolution has no concept of package exports beyond "main"/"types". Passing --profile node16 aligns the standalone prepublish check with the compatibility target this package already states everywhere else.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.4.0 release (adding the new `cc-peer/alias-pool` subpath export) failed at the npm publish step: `attw --pack` defaults to its own "strict" profile, which includes node10 (pre-exports-field) resolution, and a genuine multi-entry subpath export cannot be resolved under node10 by design (legacy resolution has no concept of package exports beyond `main`/`types`). tsdown's own build-time attw check already targets node16 explicitly; this aligns the standalone prepublish check with the same, already-stated compatibility target.
semantic-release had already created and pushed the `v1.4.0` git tag and version-bump commit before the npm publish step failed, so no GitHub release or npm package exists for that version. The next successful release picks up from here.
Verified locally: `pnpm build && attw --pack --profile node16` and `publint` both pass clean.