fix: declare sibling dependencies as plain versions so published manifests are installable - #49
Merged
Merged
Conversation
…fests are installable The release publishes through npm, which copies package.json verbatim and does not understand the pnpm workspace protocol. The `workspace:^` dependencies of trilean and trilean-sql therefore reached the registry unchanged and made both fail to install with EUNSUPPORTEDPROTOCOL. Plain versions are rewritten by the release orchestrator when a sibling releases, and pnpm still links the workspace copies because linkWorkspacePackages is on.
…dencies pnpm's default is to save `workspace:^` when adding a sibling, which the npm-based release then publishes verbatim as an uninstallable range. With saveWorkspaceProtocol off, adding a sibling writes the plain exact version instead. Also drops a comment claiming the workspace holds a single package.
Mearman
marked this pull request as ready for review
September 19, 2026 11:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trilean 1.5.0 to 1.6.1 and trilean-sql 2.2.0 were published with
workspace:^dependencies still in their manifests, sonpm install trilean(and anything depending on it, e.g. wire-mesh-core) fails with EUNSUPPORTEDPROTOCOL. The release goes through@semantic-release/npm, which runs plainnpm publishand copies package.json as it is. The orchestrator treats bareworkspace:^as "pnpm resolves it at pack time", but nothing packs with pnpm here.This switches the three sibling edges (trilean -> trilean-regex, trilean-sql -> trilean and trilean-regex) to plain exact versions matching what is currently released, which is what documents.js does. The orchestrator rewrites those ranges itself when a sibling releases, and
linkWorkspacePackagesstill symlinks the workspace copy locally (checked: packages//node_modules/trilean point back into packages/).I also turned
saveWorkspaceProtocoloff, since pnpm's default writesworkspace:^onpnpm add <sibling>, which is how this got here. Checked both ways: without the settingpnpm add trilean-regex --filter trileanwritesworkspace:^, with it1.0.2.Packed all three packages with
npm packand none of the packed manifests contain aworkspace:specifier.