build(deps-dev): bump tsdown, better-sqlite3 and vitest majors - #50
Merged
Merged
Conversation
Mearman
changed the title
Mearman
marked this pull request as ready for review
September 19, 2026 15:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
enabled auto-merge (rebase)
September 19, 2026 15:48
Bumped in every package together, since each builds with the same tsdown config. None of the removed or renamed options are used by these configs, and the build, typecheck (including attw), unit, integration, smoke and workers suites all pass.
Version 13 moved to N-API and ships a prebuilt binary per platform inside the package, loaded from prebuilds/ at runtime, so its install-time node-gyp build is no longer needed. allowBuilds now records that as a refusal instead of a permission. The SQLite integration suite passes against the prebuilt binary with no build/ directory present, alongside the rest of the unit, integration (including PostgreSQL), smoke and workers suites.
@vitest/coverage-v8 moves with it because it peers on the exact vitest version.
Unit, coverage, and integration suites (including SQLite and PostgreSQL) pass unchanged.
packages/trilean stays on vitest 4.
Its workers project runs through @cloudflare/vitest-pool-workers,
whose vitest peer range is ^4.1.0,
and with vitest 5 the pool fails to start
("Failed to start cloudflare-pool worker", SyntaxError: Unexpected identifier 'file').
Mearman
force-pushed
the
build/dependency-major-updates
branch
from
September 19, 2026 15:58
a7c538f to
ea9a4f2
Compare
|
🎉 This PR is included in trilean-regex@1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in trilean-sql@2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the tsdown, better-sqlite3 and vitest major bumps as one change across the root lockfile and the packages, instead of the per-directory Dependabot PRs (each of which carried the whole workspace lockfile anyway).
tsdown 0.23.0: none of the removed or renamed options appear in the three tsdown configs. Build, typecheck with attw, and every test project pass.
better-sqlite3 13.0.3: v13 is N-API with a prebuilt binary per platform inside the package (prebuilds/.node), loaded at runtime, so the install-time node-gyp build is gone. It's set to false in allowBuilds now, and the SQLite integration suite passes with no build/ directory present. The Postgres integration suite (testcontainers) passes locally too. The comment next to the entry says why.
vitest 5.0.1 with @vitest/coverage-v8 (which peers on the exact vitest version), in trilean-regex and trilean-sql only. packages/trilean stays on 4.1.x because @cloudflare/vitest-pool-workers peers on vitest ^4.1.0 and its worker fails to start under vitest 5 (tracked in #52).
Not included: TypeScript 7, tracked in #53 (typescript-eslint refuses to run on it).
Supersedes #23, #24, #36, #37, #39, #40, #41 and #42. #35 and #38 (vitest for the root and packages/trilean) and #17 (typescript) are closed with the reasons above.