Preliminary support for enum deserialization on PG#28
Draft
cies wants to merge 1 commit intoExoQuery:mainfrom
Draft
Preliminary support for enum deserialization on PG#28cies wants to merge 1 commit intoExoQuery:mainfrom
cies wants to merge 1 commit intoExoQuery:mainfrom
Conversation
Signed-off-by: cies <cies-AT@kde-DOT.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at #21 . I found that enums where not supported (as per
TODO()s in the code base that this PR implements).There are some tests. Only for PG for now (I post this PR as a draft).
I would not mind to create working test for all platforms, but that's take more time and I first would like a review of the work thus far to know if I'm in the right direction and if a contribution like this is even considered for merging.
As it could be a strategic decision not to allow enums, as they may not be needed for downstream ExoQuery libraries, and/or this would also put more eyes on supporting enums in the Terpal compiler plugin as well (which may require adding a dependency to that project, like kotlinx.serialization or reflection; see ExoQuery/Terpal#17 ).
Looking fwd to you response. No hurry. And "no" is also a valid answer. :)