Skip to content

Stop the wind particles flickering on Android - #586

Merged
whes1015 merged 1 commit into
mainfrom
fix/wind-particles-render-pass
Oct 1, 2026
Merged

whes1015 merged 1 commit into
mainfrom
fix/wind-particles-render-pass

Conversation

@whes1015

@whes1015 whes1015 commented Oct 1, 2026

Copy link
Copy Markdown
Member

這個 PR 做了什麼

把 maplibre fork 從 9804c2f9 升到 48bce744。這段範圍內 fork 的修改:

  • 71d58c4 iOS:風場粒子改在地圖的 Metal pass 內繪製
  • 403330f Android:粒子改由 MapLibre custom layer 承載
  • f51a147 Android:修正粒子閃爍
  • 48bce74 iOS:把地圖的 render pass 交給 composite

四個 ref 一起升級:兩個直接相依加兩個 dependency_overrides。pubspec 的註解要求它們指向同一個 fork commit,否則 setRenderPaused 等 API 會在部分平台上不存在。pubspec.lock 是在移開 pubspec_overrides.yaml 的狀態下重新產生的,裡面沒有本機路徑。

相關 issue

怎麼驗

  • tool/check.sh 全過(pre-push 跑過),tool/dev/analyze.sh 無問題,test/features/map 351 個測試通過。
  • 尚未在實機上看過:請在 Android 和 iOS 上開風場預報圖層,確認粒子不閃爍、拖動與縮放時跟著地圖走。

Platform: all

Fix(zh-Hant): 修正 Android 上風場粒子閃爍,iOS 的風場粒子改在地圖同一個繪製流程中畫出
Fix(en-US): the wind particles no longer flicker on Android, and on iOS they draw in the map's own render pass
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

@whes1015
whes1015 enabled auto-merge (rebase) October 1, 2026 20:26
@whes1015
whes1015 disabled auto-merge October 1, 2026 20:33
@whes1015
whes1015 merged commit af88c54 into main Oct 1, 2026
6 checks passed
@whes1015
whes1015 deleted the fix/wind-particles-render-pass branch October 1, 2026 20:33
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.37%. Comparing base (c193f41) to head (af88c54).
⚠️ Report is 2 commits behind head on main.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant