Stop the wind particles flickering on Android - #586
Merged
Merged
Conversation
Platform: all Fix(zh-Hant): 修正 Android 上風場粒子閃爍,iOS 的風場粒子改在地圖同一個繪製流程中畫出 Fix(en-US): the wind particles no longer flicker on Android, and on iOS they draw in the map's own render pass
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
whes1015
enabled auto-merge (rebase)
October 1, 2026 20:26
whes1015
disabled auto-merge
October 1, 2026 20:33
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
把 maplibre fork 從
9804c2f9升到48bce744。這段範圍內 fork 的修改:71d58c4iOS:風場粒子改在地圖的 Metal pass 內繪製403330fAndroid:粒子改由 MapLibre custom layer 承載f51a147Android:修正粒子閃爍48bce74iOS:把地圖的 render pass 交給 composite四個 ref 一起升級:兩個直接相依加兩個
dependency_overrides。pubspec 的註解要求它們指向同一個 fork commit,否則setRenderPaused等 API 會在部分平台上不存在。pubspec.lock是在移開pubspec_overrides.yaml的狀態下重新產生的,裡面沒有本機路徑。相關 issue
怎麼驗
tool/check.sh全過(pre-push 跑過),tool/dev/analyze.sh無問題,test/features/map351 個測試通過。