[DO NOT MERGE][TEST] verifyPeerReview ruleset bypass (fork) - #140
Closed
roryabraham wants to merge 1 commit into
Closed
[DO NOT MERGE][TEST] verifyPeerReview ruleset bypass (fork)#140roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
Benign marker-only security test for Expensify/Expensify#636197. Injects a local verifyPeerReview.yml and a failing package.json postinstall to validate the org-ruleset path never executes fork PR-head code. Do not merge.
|
|
Collaborator
Author
|
Closing: App-Test-Fork ruleset verifyPeerReview security test complete; defenses held. Results posted to Expensify/Expensify#636197. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benign security test for https://github.com/Expensify/Expensify/issues/636197.
Fork PR variant validating the org-ruleset-injected
verifyPeerReviewcheck on App-Test-Fork. Injects a localverifyPeerReview.yml(marker +exit 1) and a failingpackage.jsonpostinstall. Expectation: the ruleset runsGitHub-Actions@mainonly; no fork PR-head code executes; secrets still work.Do not merge. Will be closed after evidence is captured.
Made with Cursor