Vacation delegate - Workspace are not arranged in alphabetical order

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #99460
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: User Settings

Action Performed:

Precondition:

• Create a few workspaces.

1. Go to staging.new.expensify.com
2. Go to Account > Profile > Status.
3. Click Vacation delegate.
4. Enter an existing user email who is not workspace member.
5. Click on the user.

Expected Result:

Workspaces will be arranged in alphabetical order.

Actual Result:

Workspace are not arranged in alphabetical order.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7262819_1789688509728.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7262819

Issue Owner

Current Issue Owner: @war-in

Issue Owner

Current Issue Owner: @war-in

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6ac948918377037ab84f2e7869c409ee8131d588dab8847c70c64350ab0f5beb

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #99460

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

@mountiny @mkhutornyi you have been assigned to this deploy blocker because you reviewed the offending PR: #99460

[melvin-bot]

@jakubstec you have been assigned to this deploy blocker because you authored the offending PR: #99460

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[MelvinBot]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: feat: Replace vacation delegate policy diff warning with RHP invite step - "feat: Replace vacation delegate policy diff warning with RHP invite step" by @jakubstec (High confidence)
Related Issues: Vacation delegate: adjust the policy diff warning (the issue PR #99460 implemented)

Recommendation: ROLL FORWARD

The bug is a missing client-side sort in a brand-new RHP page — a few-line fix in WorkspaceSection/index.tsx is far safer and smaller than reverting a 5-file, ~380-line feature PR (plus 612 lines of tests) that also removed the old blocking policy-diff warning it replaced. Reverting would restore the previously-rejected warning UX to fix a purely cosmetic ordering issue.

Assigned: @jakubstec (PR author), @mountiny and @mkhutornyi (approving reviewers) from highest-confidence causing PR only — already assigned by melvin-bot, no change needed
Labels: No changes. DeployBlockerCash is kept (an App PR caused this, and the issue is not reproducible on production). DeployBlocker was not present, so nothing was removed.

📋 Detailed Analysis

Evidence

• The reported screen — the RHP that lists the workspaces a vacation delegate is missing from, shown after picking a non-member user — did not exist before PR feat: Replace vacation delegate policy diff warning with RHP invite step #99460. The PR description states it "Replaces the vacation delegate's blocking 'policy diff' warning with an RHP step (VacationDelegateMissingWorkspacesPage)".
• All five files that make up that page are pure additions in PR feat: Replace vacation delegate policy diff warning with RHP invite step #99460 (MissingWorkspacesFooter.tsx +63, MissingWorkspacesIntro.tsx +48, WorkspaceRow.tsx +50, WorkspaceSection.tsx +48, index.tsx +174), confirmed via gh pr view 99460 --json files.
• PR feat: Replace vacation delegate policy diff warning with RHP invite step #99460 merged 2026-09-17T10:50:43Z and is item 17 in the chronological list of Deploy Checklist: New Expensify 2026-09-17 for 9.4.84-0 — the exact version reported.
• Consistent with "Reproducible in production?: N/A - new feature, doesn't exist in prod": the page itself is new to this release, so the bug cannot exist in production.
• The unsorted render is visible in the PR diff itself, including the comment that documents the behaviour as intentional-by-omission: /** Workspaces to list, in the order the policy diff returned them. Nothing is rendered when empty. */

Verification

Affected files (all added by PR #99460):

• src/pages/settings/Profile/CustomStatus/VacationDelegateMissingWorkspacesPage/WorkspaceSection.tsx#L36-L43 — the render loop, no sort applied
• src/pages/settings/Profile/CustomStatus/VacationDelegateMissingWorkspacesPage/WorkspaceSection.tsx#L16-L18 — the prop doc confirming backend ordering is used verbatim
• src/pages/settings/Profile/CustomStatus/VacationDelegateMissingWorkspacesPage/index.tsx#L57-L60 and #L153-L162 — where the two ID arrays are read off policyDiff and passed straight to WorkspaceSection

A repo-wide grep for policyDiff|adminPolicies|nonAdminPolicies across src/ shows no sort or localeCompare anywhere in this flow, so the omission is not compensated for further up or down the chain. No test in tests/ui/VacationDelegateMissingWorkspacesPageTest.tsx asserts row ordering, so adding a sort will not break existing tests.

Root Cause

policyDiff is stored verbatim from the SetVacationDelegate 305 (POLICY_DIFF_WARNING) response into the vacation-delegate NVP (src/libs/actions/VacationDelegate.ts#L102-L110). Its adminPolicies and nonAdminPolicies are plain string[] of policy IDs (src/types/onyx/VacationDelegate.ts#L4-L11) whose order carries no meaning.

index.tsx passes those arrays through unchanged, and WorkspaceSection maps over policyIDs directly to render one WorkspaceRow each. Because the display name is only resolved inside WorkspaceRow (policy?.name ?? translate('workspace.common.unavailable')), the list is ordered by whatever sequence the API returned the IDs in, never by the name the user actually sees. Hence the non-alphabetical order.

This is squarely an App-side fix: the response is well-formed and the ordering of an ID array is not something the backend should be relied on to guarantee — presentation order belongs in the client.

Suggested fix: resolve each row's title in WorkspaceSection and sort by it with the locale-aware comparator before rendering, matching the pattern used elsewhere in the app (const {translate, localeCompare} = useLocalize();, then sort). Two things to be careful about:

1. Do not sort in place. policyIDs is the Onyx-owned array (vacationDelegate.policyDiff.adminPolicies); .sort() mutates its receiver, so copy first ([...policyIDs].sort(...)).
2. Sort by the resolved title (including the workspace.common.unavailable fallback), not by policyID, so the order matches what is rendered. No useMemo — this file compiles under React Compiler.

adminWorkspaces in index.tsx (used for the actual invite call) is unaffected; its order has no user-visible or functional meaning.