Repository navigation
[Due for payment 2026-10-07] Payment issue for E/App PR#102338 #102703
Description
Activity
@mkhutornyi The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Contributor+ Checklist:
-
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: new feature
Link to the comment on the Issue: -
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
- Use a Collect workspace with Workflows enabled, reimbursements set to pay with Expensify, and a business bank account connected.
- Go to Workspace → Workflows → Expense report rules.
- Verify Auto-pay approved reports shows a lock and the subtitle "Auto-pay is only available on the Control plan. Upgrade to unlock this feature."
- Click the Upgrade link and verify it opens the upgrade page for auto-pay.
- Go back and tap the switch. Verify it also opens the upgrade page and auto-pay is not enabled.
- Remove the bank account (or use a Collect workspace without one). Verify the row still shows the Control-plan copy, not "Add payments to unlock this feature", and tapping still opens the upgrade page.
- Upgrade the workspace to Control. Verify the lock goes away, the subtitle reads "Configure which expense reports are eligible for auto-pay.", and the switch enables auto-pay.
- On a Control workspace with no bank account, verify the row keeps the existing "Add payments to unlock this feature" copy and the switch is locked.
Do we agree 👍 or 👎
-
Deploy Blocker #102619 was identified to be related to this PR.
False alarm. The real offending PR was https://github.com/Expensify/Mobile-Expensify/pull/14144
Reason: #102619 (comment). After that fix, no longer reproducibleTriggered auto assignment to @mallenexpensify (
Awaiting Payment)Payment Summary
- Reviewer: @mkhutornyi owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
- I have confirmed assignees, roles, and Upwork contracts look correct
- I have paid out Upwork contracts / manual NewDot requests
- [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Payment Summary
Contributor+: @mkhutornyi due $175 via NewDot
Issue created to compensate the Contributor+ member for their work on #102338
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/681099.
Contributor+ member who reviewed the PR - @mkhutornyi.
Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
Issue Owner
Current Issue Owner: @mallenexpensify