Repository navigation
[Due for payment 2026-10-07] Payment issue for E/App PR#100248 #102706
Description
Activity
@truph01 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)Payment Summary
- Reviewer: @truph01 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
- I have confirmed assignees, roles, and Upwork contracts look correct
- I have paid out Upwork contracts / manual NewDot requests
- [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Deploy Blocker #102604 was identified to be related to this PR.
@truph01 this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
I see the other deploy blocker doesn't lower the price here, unsure about this one. Please post on the payment issue with every mention of regressions and deploy blockers on an issue and from the PR.
@truph01 plz complete the Contributor+ checklist and tag me in a post once you have. Thx
Please post on the payment issue with every mention of regressions and deploy blockers on an issue and from the PR.
Posted two comments #100248 (comment) and #100248 (comment)
Contributor+ Checklist:
-
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue: -
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Test case 1:
- Go to WS -> Category -> More -> Settings
- Verify that:
Auto-categorize new expensesis shown and enabled by default - Verify that we can disable/enable it
- Create an expense in that WS without category
- Verify that the category is missing if
Auto-categorize new expensesis disabled and the category is added automatically whenAuto-categorize new expensesis enabled
Test case 2: Verify the changelog in admin room when disbale/enable auto-cateogrize
- Go to staging.new.expensify.com
- Go to workspace settings > Categories > Settings.
- Disable and enablel Auto-categorize new expenses.
- Go to #admins.
- Verify that the changelog for auto-categorisation settings will appear in #admins.
Test case 3: Workspace - Auto categorization settings will be disabled in the duplicated workspace if the original one has been disabled
- Go to staging.new.expensify.com
- Go to workspace settings > Categories > Settings.
- Disable Auto-categorize new expenses.
- Go back to workspace list.
- Click 3-dot menu on the workspace > Duplicate workspace > Next > Continue.
- Open duplicated workspace settings > Categories.
- Click Settings.
- Verify that: auto categorization settings are disabled in the duplicated workspace.
Test case 4: Expense - Expense isn't auto categorized after disabling auto categorisation
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create an expense with category.
- Go to workspace settings > Categories > Settings.
- Disable Auto-categorize new expenses.
- Go to workspace chat.
- Create an expense with the same merchant in Step 3 and without category.
- Open the expense.
- Verify that: The new expense will not be auto categorized.
Do we agree 👍 or 👎
-
Issue created to compensate the Contributor+ member for their work on #100248
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/669240.
Contributor+ member who reviewed the PR - @truph01.
Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
Issue Owner
Current Issue Owner: @mallenexpensify