Skip to content

Accountings- Account number not displayed in Reimbursable account #102723

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.0-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102129
Email or phone of affected tester (no customers): applausetester+dk54@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 Chrome
App Component: Workspace Settings

Action Performed:

Preconditions:

  • Use Expensifail account, Enable the businessCentral beta for your account (on dev: Account > Troubleshoot > Beta overrides)
  • Create a workspace and connect Dynamics 365 Business Central
  1. Open https://staging.new.expensify.com/
  2. Navigate to Workspace settings
  3. Click on 'Accountings'
  4. Click on 'Export'
  5. Change Transaction date to Submitted date
  6. Click on 'Reimbursable account'
  7. Select any bank account

Expected Result:

verify the row shows the account number and name.

Actual Result:

There is only bank account name, the account number is missing

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7274100_1790829518152.bandicam_2026-10-01_11-33-11-292.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7274100

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 1, 2026
  2. applause-bot commented on Oct 1, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b9d19702948625a08cd075fc6de34bf47e6491e41a31cec8f1853aa587b5f26a

  3. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    @NikkiWines recently merged #102129, but they are OOO right now, so I'll auto-assign someone else.

  4. github-actions commented on Oct 1, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    @francoisl @NikkiWines @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #102129

  7. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    @c3024 you have been assigned to this deploy blocker because you authored the offending PR: #102129

  8. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  9. MelvinBot commented on Oct 1, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Recommendation: demote, don't revert. Most likely the bank account data has an empty number, so only the name shows. The App code shows the number whenever the data has one. The feature is behind the businessCentral beta, and the bug only affects a label.

    Causing PR: [BC][Release 2]Add the Business Central Export page and settings. It added this page, and its test step 6 says the row should show "the account number and name". So this is not expected behavior. Confidence: medium.

    Next step: an internal engineer should check the bankAccounts entries stored for the tester's Business Central connection (applausetester+dk54@applause.expensifail.com). If number is empty there, this appears to be a backend/internal issue, and a separate internal investigation is needed. If the backend sends the number under a different field name, update the App type and the 4 lines below to use it.

    Investigation details
    • The row text joins the number and the name: BusinessCentralExportPage.tsx:82. The picker list does the same: BusinessCentralReimbursableAccountSelectPage.tsx:43.
    • If number were missing, the row would read "undefined <name>". Seeing only the name means number is most likely an empty string.
    • The BusinessCentralBankAccount type in Policy.ts:2577-2589 was added in an earlier PR, before real backend data existed. It was never checked against that data. A later PR had to fix the Dimension type for the same reason.
    • The Company card account row has the same pattern, so expect the same bug there: BusinessCentralExportPage.tsx:103.
    • Exports still use the right account, because the selection is saved by account id, not by its label.
    • Changing the transaction date to "Submitted date" has nothing to do with the bug.
    • Optional hardening: build the label with [account.number, account.name].filter(Boolean).join(' '). A missing number then can't show "undefined" or a leading space. This doesn't bring the number back.
    • Not verified: I didn't check the stored backend data, and I didn't reproduce the bug in the app.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  10. c3024 commented on Oct 1, 2026

    @c3024
    Contributor

    The test step 6 is

    Pick a Reimbursable account from the company's bank accounts and verify the row shows the account number and name.

    The row shows both account number and name and account numbers can be free text codes. In this case the account numbers are CHECKING and SAVINGS.

    So this is ot a bug. In the CRONUS USA demo company the bank accounts are numbered CHECKING and SAVINGS, and both are named World Wide Bank. The row in the video shows CHECKING World Wide Bank, which is the account number followed by the name, as the test step expects. The number comes from the bank account's number field in Business Central.

    cc: @NikkiWines @MelvinBot

  11. MelvinBot commented on Oct 1, 2026

    @MelvinBot
    Contributor

    Agreed, c3024: this is not a bug, and my earlier analysis was wrong. I assumed the account number would be digits.

    The App builds the row as the number, a space, then the name (BusinessCentralExportPage.tsx:82). So "CHECKING World Wide Bank" is the number "CHECKING" followed by the name "World Wide Bank". That matches step 6 of [BC][Release 2]Add the Business Central Export page and settings.

    I couldn't open the video myself. This is based on your description and the code.

    Nothing needs to be fixed or reverted. An assignee can remove DeployBlockerCash and close this issue.


    view run

  12. IuliiaHerets commented on Oct 1, 2026

    @IuliiaHerets

    @c3024, can we check it off then if it is expected?

  13. c3024 commented on Oct 1, 2026

    @c3024
    Contributor

    I think yes.

    cc: @NikkiWines @francoisl

  14. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 1, 2026
  15. rlinoz commented on Oct 1, 2026

    @rlinoz
    Contributor

    I guess we can actually close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions