[Exploratory] Wallet - Locked bank account isn't tapped on the workflow payments page while offline

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: v9.4.57-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/70015375/folder/54018437/98914477/1678450847?sort=%2Bidentifier
Email or phone of affected tester (no customers): applausetester+lockedba@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Honor x6b / Android 16, Windows 10 / Chrome
App Component: User Settings

Action Performed:

Preconditions: Log in with applausetester+lockedba@applause.expensifail.com

1. Ensure the app has loaded the locked state while online
2. Disconnect from the network or enable Airplane mode
3. Navigate to Account Settings and then to Wallet
4. Verify the locked bank account row is disabled and non-interactive
   Result: Locked Bank Account row is enable and can be tapped while online

Expected Result:

The locked bank account row is disabled and non-interactive

Actual Result:

Locked Bank Account row is enable and can be tapped while online

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7238324_1787236921136.video4916070702882228420.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7238324

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022090460660668600103
• Upwork Job ID: 2090460660668600103
• Last Price Increase: 2026-08-20

Issue Owner

Current Issue Owner: @Julesssss

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6dd9ffaad284aa246d4eaf9572619ea6d6be8670365316f39a0b047a1f86d296

[MelvinBot]

Proposal

Root cause (medium confidence): The locked bank account row in Wallet has no offline guard, so it stays interactive when you go offline — tapping it still fires the "unlock" flow. QA expects a locked row to be disabled and non-interactive while offline, but nothing in the render chain disables it.

What is the root cause of that problem?

A business bank account in the LOCKED state is flagged as locked in PaymentMethodListItem.tsx:136-138. When that row is pressed, handleRowPress (PaymentMethodListItem.tsx:163-178) routes the tap to the locked-account handler, which calls pressLockedBankAccount (BankAccounts.ts:1828) and navigates to Concierge to request an unlock.

Nothing in that path checks the network state:

• The only disabled value set for a bank account row is for delete-pending rows — PaymentMethodList.tsx:621 (disabled: paymentMethod.pendingAction === ...DELETE).
• isOffline in PaymentMethodList is used only to filter out delete-pending methods — PaymentMethodList.tsx:554 — never to disable the locked row.
• handleRowPress and the locked branch in WalletPage/index.tsx:160-164 have no isOffline check.

So while offline the locked row remains pressable and the unlock flow still runs.

What changes do you think we should make in order to solve the problem?

Gate the locked bank account row on the network state. In PaymentMethodListItem, read isOffline (via useNetwork) and, when the row isInLockedState and the app is offline, mark the row disabled (so MenuItem renders it non-interactive) and short-circuit handleRowPress so the unlock/Concierge navigation does not fire. This keeps the locked row visible (with its "Locked" badge) but disabled and non-interactive while offline, matching the expected result.

Investigation details, scope, and alternatives considered

Why this row is special: the locked-state branch bypasses the normal three-dots menu and directly triggers a server-dependent unlock/Concierge flow. That's the interaction QA expects to be blocked offline.

Alternative considered: disable at the list level in PaymentMethodList.formatPaymentMethods/computeFilteredPaymentMethods by setting disabled when isOffline && locked. This also works, but the locked-state detection (isBusinessBankAccountLocked) already lives in PaymentMethodListItem, so guarding there is the most localized change and avoids duplicating the locked-state check.

Could not reproduce live: reproduction requires an account with a business bank account in the LOCKED state (the applausetester+lockedba account). The standard test account can't be placed into that state, so this analysis is code-based rather than confirmed by a live offline repro. The report's own wording is also internally inconsistent ("...tapped while online" vs. steps that say to go offline first) — the steps and Expected Result make clear the intended check is the offline state.

Possibly related: #98998 (Locked BA - After going online and clicking Pay Locked BA modal is not shown) — also in the locked bank account area, but a different symptom.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/99082) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

---

view run

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022090460660668600103

[dilshodmackbook-sketch]

@Pujan92 I think Melvin's proposal is pointing at the wrong code path for what's actually in the video, so its fix wouldn't resolve this repro.

In the recording the locked row shows a three-dots menu plus a "This account requires attention" message with an Unlock button, and "You appear to be offline" is visible. That UI is the WALLET_CONNECTION_STATUS beta path. Melvin's fix targets isBusinessBankAccountLocked / handleRowPress in PaymentMethodListItem, but on this row the three-dots menu is rendered, and that only happens when isInLockedState is false (showThreeDotsMenu = item.shouldShowThreeDotsMenu !== false && !!threeDotsMenuItems && !isInLockedState). So the locked-row branch it guards isn't the one firing here.

The element that's actually interactive offline is the Unlock button from the connection-status message:

• getBankAccountConnectionStatus maps the LOCKED state to an action with requiresUnlockHandler: true (src/libs/BankAccountUtils.ts).
• mapBankStatusToRowStatus builds that action's onActionPress but never sets isActionDisabled and never checks the network (src/pages/settings/Wallet/PaymentMethodList.tsx, ~L245).
• ConnectionStatusMessage already wires isActionDisabled → Button.isDisabled, so the disable hook exists end-to-end — it's just always false.
• Pressing it runs onUnlockPress → paymentMethodPressed → pressLockedBankAccount + navigateToConciergeChat, which is why the offline taps queue those "request to unlock your bank account" messages in Concierge.

Complete fix that covers both the beta and non-beta paths:

1. Disable the Unlock button while offline in mapBankStatusToRowStatus — isActionDisabled: !!status.requiresUnlockHandler && isOffline (isOffline is already read via useNetwork in this component, ~L211). This greys it out and blocks the press.
2. As defense-in-depth for the non-beta plain locked-row tap, no-op the LOCKED branch in paymentMethodPressed when network.isOffline (src/pages/settings/Wallet/WalletPage/index.tsx, ~L160; network is already available there). Both routes funnel through this handler, so this also blocks the row-body path.

Happy to write this up as a full proposal if that's useful.