Skip to content

[No QA] Fix import/no-cycle - part 12 - #101419

Draft
LukasMod wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/no-cycle-part12-report-action-subscribers
Draft

[No QA] Fix import/no-cycle - part 12#101419
LukasMod wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/no-cycle-part12-report-action-subscribers

Conversation

@LukasMod

@LukasMod LukasMod commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Part 12 of the import/no-cycle series.

Task.ts, IOU/Hold.ts, and Session/index.ts each import the Report actions hub (src/libs/actions/Report/index.ts) or actions/Link to reach one helper that has nothing else to do with those files. This PR moves each helper into a leaf module and points the caller at it, so no caller needs the hub for it anymore.

  • Report/reportActionSubscribers.ts now holds notifyNewAction and subscribeToNewActionEvent. The registry is a module-scope array that imports only the ReportAction type. Report/index.ts re-exports both names, so useReportActionsNewActionLiveTail and MoneyRequestReportActionsList keep subscribing through the hub. IOU/Hold.ts and Task.ts import the leaf. Eight more modules call notifyNewAction (Chronos.ts plus seven IOU payment flows). They already pull other functions from the hub, so they keep that import and this PR leaves them for a later part.
  • Task/TaskDeletion.ts now holds deleteTask, clearTaskErrors, and getNavigationUrlOnTaskDelete. Those three were the only reason Task.ts imported the hub: they need navigateToConciergeChatAndDeleteReport, getMostRecentReportID, and optimisticReportLastData. TaskView and DynamicReportDetailsPage import them from the new path, and the bodies are unchanged.
  • actions/buildOldDotURL.ts and src/libs/openExternalLink.ts are new leaves. buildOldDotURL reads the current email from CurrentUserStore, which replaces the ONYXKEYS.SESSION mirror Link.ts kept for it. Session/index.ts imports both leaves and drops Link.ts entirely. Link.ts still re-exports openExternalLink, since 25 modules import it from there, and drops the buildOldDotURL re-export that knip flagged once Session stopped using it.

npx oxlint src -c .oxlintrc.no-cycle.json reports 261 findings across 82 files on this branch, down from 264 across 82 files at the merge base. One cycle per repointed import: Task.ts 8 to 7, Session/index.ts 9 to 8, IOU/Hold.ts 6 to 5. Parts 8 through 11 are still open and remove parallel paths, so the combined drop is larger than what any single branch shows on its own.

Nothing here touches the UI or adds a dependency.

Fixed Issues

$ #99650
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Test 1: Live message in the open report

Covers notifyNewAction in its new module. Smoke check only: the list renders from the report actions data, so this catches load and runtime errors, not a missed notification.

  1. In the A window, open Report 1:1 and leave it on screen.
  2. In the B window, send a message into Report 1:1.
  3. Back in the A window, confirm the message renders without reloading or navigating away.
  4. Send one message from each side. Confirm both render correctly.

Test 2: Delete a task that is the only comment

Covers deleteTask, getNavigationUrlOnTaskDelete, and the Task/TaskDeletion import path in DynamicReportDetailsPage.

  1. Open the task, then its details, then delete it.
  2. Confirm the app lands on the parent report.
  3. Confirm the task preview is gone from the parent.
  4. Confirm no console errors.

Test 3: OldDot link keeps the email param

Covers buildOldDotURL and openExternalLink. The email now comes from CurrentUserStore instead of the mirror Link.ts used to keep, so that param is the thing to watch.

  1. Open Settings, then Troubleshoot, then Go to Expensify Classic.
  2. Confirm the external tab opens an OldDot URL containing email=<your email>, with a single separator before it and no doubled ? or &.
  3. Confirm OldDot opens you as signed in. An authToken in the URL is expected, though a missing one is also fine: the request for it falls back to no token.
  4. Turn the network off and repeat. Confirm the URL still carries email=<your email> and now has no authToken.

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Test1:

web.1.mov

Test2:

web-2.mov

Test 3:

web-3.mov

@codecov

codecov Bot commented Sep 17, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ReportActionItem/TaskView.tsx 85.71% <ø> (ø)
src/libs/actions/IOU/Hold.ts 93.39% <ø> (ø)
src/libs/actions/Link.ts 58.90% <ø> (+3.13%) ⬆️
src/libs/actions/Report/index.ts 71.50% <ø> (-0.22%) ⬇️
src/libs/actions/Report/reportActionSubscribers.ts 100.00% <100.00%> (ø)
src/libs/actions/Session/index.ts 61.71% <ø> (ø)
src/libs/actions/Task.ts 65.46% <ø> (-2.25%) ⬇️
src/libs/actions/buildOldDotURL.ts 100.00% <100.00%> (ø)
src/libs/openExternalLink.ts 100.00% <100.00%> (ø)
src/pages/DynamicReportDetailsPage.tsx 69.85% <ø> (ø)
... and 1 more
... and 196 files with indirect coverage changes

@LukasMod
LukasMod force-pushed the fix/no-cycle-part12-report-action-subscribers branch 3 times, most recently from be1e316 to 876c8a6 Compare September 17, 2026 12:54
@LukasMod
Cut three cycles out of the Report and Task hubs
78d61c1 
Move the new-action subscriber registry into Report/reportActionSubscribers and
the task deletion paths into Task/TaskDeletion, so action modules can notify
subscribers or cancel a task without importing the Report hub. buildOldDotURL
and openExternalLink become leaves too, which lets actions/Session drop its
dependency on actions/Link. Each hub keeps re-exporting the names callers still
reach it for, so those imports are unchanged.

Drop the buildOldDotURL re-export from actions/Link and the SubscriberCallback
type export, both dead once Session moved to the leaf.

import(no-cycle) findings drop 264 -> 261 on this base; the wider -55 in the
plan stays gated on parts 8-11 landing.
@LukasMod
LukasMod force-pushed the fix/no-cycle-part12-report-action-subscribers branch from 876c8a6 to 78d61c1 Compare September 17, 2026 13:22
@LukasMod

LukasMod commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

1 similar comment
@LukasMod

LukasMod commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LukasMod LukasMod

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LukasMod