Conversation
linkingConfig subscribe() imported hasAuthToken from actions/Session, which drags the whole session layer into its import graph and keeps an import cycle alive. CurrentUserStore already connects to ONYXKEYS.SESSION for the email, so hasAuthToken moves there and actions/Session keeps re-exporting it for existing callers. Also applies the oxfmt import order in subscribe.ts that the oxfmt CI gate enforces.
Used to verify the linkingConfig -> actions/Session cycle stays gone. Not wired into the build yet: oxlint is not a dependency, so nothing in scripts/lint or the workflows runs this config.
.oxlintrc.no-cycle.json is a scratch config used to verify the cycle is gone, not build input, so it stays out of the tree. The import order in subscribe.ts is the only remaining deviation from the draft: oxfmt CI enforces it.
The two added lines restated the import graph, which the exports already show. The pre-existing block still describes why the file exists apart from NetworkStore.
Nothing in subscribe()'s graph calls it during the test, so the factory only needs hasAuthToken.
Contributor
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
linkingConfig subscribe() imported hasAuthToken from actions/Session, which drags the whole session layer into its import graph and keeps an import cycle alive. CurrentUserStore already connects to ONYXKEYS.SESSION for the email, so hasAuthToken moves there and actions/Session keeps re-exporting it for existing callers.
Also applies the oxfmt import order in subscribe.ts that the oxfmt CI gate enforces.
Fixed Issues
$ #99650
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari