Conversation
GCyganek
marked this pull request as ready for review
September 17, 2026 14:48
melvin-bot
Bot
requested review from
garrettmknight and
getusha
and removed request for
a team
September 17, 2026 14:48
AndrewGable
self-requested a review
September 17, 2026 16:39
AndrewGable
approved these changes
Sep 17, 2026
Contributor
Author
|
In case something happens here @jmusial will take over as I'm OOO next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Improves GPS trip tracking accuracy in
IOURequestStepDistanceGPS/const.ts: lowersGPS_DISTANCE_INTERVAL_METERSfrom 100m to 50m so location updates are recorded twice as often, and setsactivityType: ActivityType.AutomotiveNavigationas it should help with getting coordinate aligned to the roads on iOS (https://developer.apple.com/forums/thread/758704).Fixed Issues
$ #101432
PROPOSAL: N/A
Tests
iOS native & Android native:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-17.at.16.23.23.mov
iOS: Native
Screen.Recording.2026-09-17.at.16.25.26.mov