Skip to content

Upgrade react-native-gesture-handler to 2.33.0 - #101447

Closed
roryabraham wants to merge 1 commit into
mainfrom
rory/upgrade-gesture-handler-2.33.0
Closed

roryabraham wants to merge 1 commit into
mainfrom
rory/upgrade-gesture-handler-2.33.0

Conversation

@roryabraham

@roryabraham roryabraham commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Upgrade react-native-gesture-handler from 2.32.0 to 2.33.0 and synchronize the npm and iOS lockfiles.

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14130

Coordinate merging with the linked Mobile-Expensify PR, which synchronizes the hybrid iOS pod lockfile with this dependency upgrade.

Upstream software-mansion/react-native-gesture-handler#4508 merged on September 11, 2026 and is included in the published 2.33.0 release. The published web declaration declares GestureStateManagerType locally, eliminating the circular import under web module-suffix resolution.

This makes the gesture-handler patch in #99495 unnecessary. That PR is still open and its patch is not on main, so this independent upgrade PR does not delete any patch files. When incorporating this upgrade into #99495, remove its patches/react-native-gesture-handler/ directory. Staying on the 2.x line avoids an unrelated major-version migration.

AI Tests

  • Passed: standalone postinstall, including application of all existing patches.
  • Passed: npm run typecheck (all five current TypeScript projects).
  • Passed: npm run lint-changed (no lintable files), npm run spell-changed, and ./scripts/validatePatches.sh (no changed patches).
  • Passed: npm test -- --silent --runInBand useReceiptHoverZoomTest (11 tests).
  • Passed: CocoaPods 1.16.2 validation that the installed podspec's version, serialized JSON checksum, and dependency list match ios/Podfile.lock. Reproducing the 2.32.0 serialized checksum matched the existing lockfile before updating it.
  • Passed: git diff --check and pre-commit hooks.
  • Full pod installation/native builds and manual cross-platform QA were not run; the worktree's Bundler dependencies are not installed. The full Jest suite was not run. The formatter excludes the changed manifest/lockfiles.

Fixed Issues

For #99287
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

// TODO: The human co-author must fill out offline verification before marking this PR as "ready for review".

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham
roryabraham requested a review from a team September 17, 2026 16:13
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@roryabraham

Copy link
Copy Markdown
Contributor Author

Closing in favor of #101442

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101447 Mobile-Expensify PR Expensify/Mobile-Expensify#14130.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d86b3e3-6c30bcb-2aef2d1419be8cf4f9061c886a63359831b88f59/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d86b3e3-6c30bcb-b86a80aeb11980eb94a7f07a52fe68aca6640fc9/index.html
Android iOS
Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant