Upgrade react-native-gesture-handler to 2.33.0 - #101447
Closed
roryabraham wants to merge 1 commit into
Closed
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
Contributor
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
Author
|
Closing in favor of #101442 |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Upgrade
react-native-gesture-handlerfrom 2.32.0 to 2.33.0 and synchronize the npm and iOS lockfiles.MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14130
Coordinate merging with the linked Mobile-Expensify PR, which synchronizes the hybrid iOS pod lockfile with this dependency upgrade.
Upstream software-mansion/react-native-gesture-handler#4508 merged on September 11, 2026 and is included in the published 2.33.0 release. The published web declaration declares
GestureStateManagerTypelocally, eliminating the circular import under web module-suffix resolution.This makes the gesture-handler patch in #99495 unnecessary. That PR is still open and its patch is not on
main, so this independent upgrade PR does not delete any patch files. When incorporating this upgrade into #99495, remove itspatches/react-native-gesture-handler/directory. Staying on the 2.x line avoids an unrelated major-version migration.AI Tests
npm run typecheck(all five current TypeScript projects).npm run lint-changed(no lintable files),npm run spell-changed, and./scripts/validatePatches.sh(no changed patches).npm test -- --silent --runInBand useReceiptHoverZoomTest(11 tests).ios/Podfile.lock. Reproducing the 2.32.0 serialized checksum matched the existing lockfile before updating it.git diff --checkand pre-commit hooks.Fixed Issues
For #99287
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
// TODO: The human co-author must fill out offline verification before marking this PR as "ready for review".
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari