Skip to content

Remove the Expensify 2FA requirement from NetSuite OAuth setup - #101452

Open
yuwenmemon wants to merge 1 commit into
mainfrom
yuwen/remove-netsuite-2fa
Open

Remove the Expensify 2FA requirement from NetSuite OAuth setup#101452
yuwenmemon wants to merge 1 commit into
mainfrom
yuwen/remove-netsuite-2fa

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@akinwale or @ShridharGoel please review

Explanation of Change

This was my bad. Netsuite OAuth should not require 2FA. It was a pattern I copied over from Xero that I should not have.

Fixed Issues

$ #101408

Tests

All four NetSuite unit suites pass (26 tests); lint, spelling, TypeScript, and React Compiler checks pass. Manual browser and device QA has not been run.

  1. Enable the netSuiteOAuth beta for a workspace admin with Expensify 2FA disabled.
  2. Open the NetSuite accounting setup and enter the NetSuite account ID.
  3. Select Connect and verify NetSuite authorization opens without an Expensify 2FA prompt.
  4. Repeat with Expensify 2FA enabled.
  5. Submit an empty account ID and verify the required-field error appears.
  6. Disable the beta and verify token-based connection and token updates work as before.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open NetSuite setup, enter an account ID, and disconnect the network.
  2. Select Connect and verify no Expensify 2FA prompt appears and no successful connection is reported.
  3. Reconnect the network and retry authorization.

QA Steps

  1. Perform the Tests and Offline tests above on staging, including mobile Safari and native apps.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@yuwenmemon
yuwenmemon requested review from a team as code owners September 17, 2026 16:52
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team September 17, 2026 16:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T17:02:28.414403Z 5dc9933 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from mjasikowski and removed request for a team September 17, 2026 16:52
@melvin-bot

melvin-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel
ShridharGoel reviewed Sep 17, 2026
View reviewed changes
Comment thread tests/unit/pages/workspace/accounting/netsuite/NetSuiteTokenInputFormTest.tsx
mockRequire2FAProps.current = {isVisible, onSubmit, onCancel};
return isVisible ? <MockView testID="require-2fa-modal" /> : null;
});
jest.mock('@components/RequireTwoFactorAuthenticationModal', () => () => <MockView testID="require-2fa-modal" />);

@ShridharGoel ShridharGoel Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed, right?

Comment thread tests/unit/pages/workspace/accounting/netsuite/NetSuiteTokenInputFormTest.tsx
beforeEach(() => {
setBetaEnabled(true);
set2FAEnabled(true);
set2FAEnabled(is2FAEnabled);

@ShridharGoel ShridharGoel Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to have the tests for 2FA on and off ? Maybe we can just leave the 2FA state to its default (like we do for other integrations except Xero I think) ?

trjExpensify
trjExpensify approved these changes Sep 17, 2026
View reviewed changes

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The Xero thing is forced upon us as a partner. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trjExpensify trjExpensify trjExpensify approved these changes
@mjasikowski mjasikowski Awaiting requested review from mjasikowski
@akinwale akinwale Awaiting requested review from akinwale
+1 more reviewer
@ShridharGoel ShridharGoel ShridharGoel left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@yuwenmemon yuwenmemon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuwenmemon @trjExpensify @ShridharGoel