Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
|
|
||
| ## How to take a photo to attach to a chat message | ||
|
|
||
| In the Expensify mobile app, **Take photo** opens a camera inside Expensify, so you stay in the app while you capture the photo. On web and mobile web, **Add attachment** opens your device's file picker instead, so there is no in-app camera. |
There was a problem hiding this comment.
Agreed — removed. Whether the camera is in-app or the system picker is an implementation detail, not something a reader needs.
Instead of explaining the platform difference in prose, I folded it into the heading using the existing house convention (## ... (Mobile only), as in Create-an-Expense.md:73 and Distance-Expenses.md:14):
-## How to take a photo to attach to a chat message
-
-In the Expensify mobile app, **Take photo** opens a camera inside Expensify, so you stay in the app while you capture the photo. On web and mobile web, **Add attachment** opens your device's file picker instead, so there is no in-app camera.
+## How to take a photo to attach to a chat message (Mobile only)I also dropped the now-orphaned in-app camera keyword from the front matter, since the article no longer uses that term.
Pushed as 017e395 — see Chat-Features-and-Moderation-Tools.md:33.
Let me know if you'd rather cut the whole section, or trim the flash/flip-camera detail in steps 5 and 7 too.
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
@MelvinBot Mark as ready |
|
A preview of your ExpensifyHelp changes have been deployed to https://23114bdc.helpdot.pages.dev ⚡️ Updated articles: |
|
There's nothing to fix in the code — every automated check on this PR passes. The one failing check, It will go green once an eligible reviewer other than the author approves. Full check status
Next step: this PR is still a draft. Reply with |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Done — this PR is now marked Ready for review. Current check status on This also confirms the earlier cleanup is clean — |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 2. Tap the **plus icon**, then select **Add attachment**. | ||
| 3. Tap **Take photo**. | ||
| 4. If Expensify asks for camera access, tap **Continue**, then allow camera access on your device. | ||
| 5. Tap the **flash** icon on the left to turn the flash on or off, or the **flip camera** icon on the right to switch between the front and back cameras. |
There was a problem hiding this comment.
Step formatting: This numbered step bundles two distinct optional actions (toggling flash and using flip camera) into one step. Per HELP_AUTHORING_GUIDELINES.md Section 5, steps should be sequential and action-oriented (one action per step). Consider splitting into two steps, or moving these optional controls out of the numbered sequence since they are not required to complete the capture.
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 017e395fa2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 4. If Expensify asks for camera access, tap **Continue**, then allow camera access on your device. | ||
| 5. Tap the **flash** icon on the left to turn the flash on or off, or the **flip camera** icon on the right to switch between the front and back cameras. | ||
| 6. Tap the **shutter** button in the center to capture the photo. | ||
| 7. Review the photo in the preview, then send it to the chat. |
There was a problem hiding this comment.
After the shutter is tapped in the native chat flow, AttachmentCamera passes the photo to handleCameraCapture, and useAttachmentPicker immediately calls addAttachment() and clearComposer(), which submits the attachment; no review screen or separate send action is shown. Telling users to review the photo and then send it therefore describes controls they cannot access and should be replaced with the actual automatic-send behavior.
Useful? React with 👍 / 👎.
| 2. Use the message bar to type a message, add an attachment, or insert an emoji. | ||
| 3. Tap the **Send** icon. | ||
| 2. Tap the field labeled **Write something...**, then type your message. | ||
| 3. To add an attachment, tap the **plus icon**, select **Add attachment**, then choose **Take photo**, **Choose from gallery**, or **Choose file**. |
There was a problem hiding this comment.
This instruction is not valid for users accessing Expensify from a mobile browser: the web/mobile-web AttachmentPicker uses a hidden file input directly and never renders the Take photo, Choose from gallery, and Choose file menu. Since the article elsewhere distinguishes mobile web from the native mobile app, label this flow as native-app-only (and clarify that mobile web opens the device file picker) so mobile-web users are not directed to nonexistent options.
Useful? React with 👍 / 👎.
3 participants
Explanation of Change
Help site follow-up for fix: use in-app VisionCamera for chat attachment photos (re-land).
That PR replaced the external system camera with an in-app VisionCamera modal when a member taps Take photo in the chat attachment picker, so Expensify stays in the foreground during capture. The in-app camera screen has its own controls (close, flash, shutter, flip camera) and its own camera-permission prompt, none of which were documented.
docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.mdpreviously described the mobile flow only as "Use the message bar to type a message, add an attachment, or insert an emoji" — it never named the attachment options and never mentioned a camera.Changes in this PR (one file):
## How to take a photo to attach to a chat messagesection covering the in-app camera: the camera permission prompt and its Continue button, the flash icon (left), shutter button (center), and flip camera icon (right), the X to close, and the fact that flash and flip camera are hidden when the device lacks a flash or a second camera.add attachment,take photo, andin-app camerakeywords so the article is retrievable for these searches.How UI labels were verified
Write something..., and the + menu shows Create expense, Track distance, Split expense, Pay Expensify, Assign task, Add attachment — with no Take photo option, confirming the in-app camera is native-only.AttachmentCameralayout.What was reviewed and left unchanged
docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md,Create-an-Expense.md,Track-Expenses.md, andTrack-Personal-Expenses.mddescribe the receipt-scanning camera, which already used an in-app camera and is not changed by the linked PR.flip camerastring added in the linked PR is an accessibility label, not visible on-screen text, so it is documented as an icon rather than a button label.Tests
Documentation only — no code changes, so there is nothing to test in the app. Verified the Markdown renders correctly and the article still uses only
#and##headings.Offline tests
Not applicable — documentation only.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
Documentation only — no UI changes.
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.