Conversation
…n Merchant Rules Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Follow-up help site change for [Payment due @bernhardoj] [No QA] Add apply to existing unsubmitted expenses toggle to personal expense rules.
That PR already updated
docs/articles/new-expensify/settings/Personal-Expense-Rules.md, so this PR only closes the remaining gap it left behind in the Merchant Rules article.The personal rule toggle now reuses the same copy as the workspace merchant rule toggle — both render
Apply to existing unsubmitted expensesfromen.ts. The Merchant Rules article still described that same toggle as"apply to existing expenses", in quotes and in lowercase. That label never existed in the UI, and now that both surfaces share one string, the two articles disagreed with each other and with the product.Changes:
Both labels were verified against the live UI on web, not just against source.
Fixed Issues
$ #100244
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes Markdown in
docs/articles. No app code is touched.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Live UI check used to confirm the exact toggle label:
@NicolasBonet, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.