Skip to content

Docs updates for E/A#101045 Add changed card number as broken connection cause - #101480

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-101045-personal-card-434
Draft

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-101045-personal-card-434

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for [Payment due @nyomanjyotisa] Fix personal card reconnection for error 434.

That PR makes the "account not found" scrape result actionable for personal cards: a personal card that fails with it now surfaces the broken connection error and the Fix card option on the Card details page, instead of silently stopping imports. In Expensify Classic this case is described to members as the account number having changed at the bank.

docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.md documented four causes of a broken personal card connection, none of which covered this one. This adds it:

  • Why a personal card connection can break — adds Your card number changed, or the account is no longer active at your bank. as a cause. Wording matches the existing company card article, which already describes this error as "Account not found / Card number changed".
  • FAQ — adds What should I do if my card number changed at the bank?, explaining that the card shows a red dot in Wallet, that the Card details page offers Fix card, and what to do if the account is closed for good.
  • Metadata — adds card number changed and account not found to keywords so members searching those phrases land here.

No other help site article needed a change. The existing steps under How to fix a broken personal card connection and the 90-day reminder behavior are unchanged by the code PR.

UI labels used here (Account, Wallet, Cards, Card details, Fix card, Update card, Time Sensitive) were verified against the current New Expensify web UI and src/languages/en.ts.

Fixed Issues

$ #101045
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Documentation-only change. npm run spell-changed passes on the edited article.

  • Verify that no errors appear in the JS console

Offline tests

N/A — help site content only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — help site content only.

Android: mWeb Chrome

N/A — help site content only.

iOS: Native

N/A — help site content only.

iOS: mWeb Safari

N/A — help site content only.

MacOS: Chrome / Safari

N/A — help site content only.


@carlosmiceli, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…on cause

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:33
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
@carlosmiceli

Copy link
Copy Markdown
Contributor

@stephanieelliott sorry to bother you, first time seeing one of these that I can remember... Should I just open it for your review?

@stephanieelliott

Copy link
Copy Markdown
Contributor

No worries @carlosmiceli! You'd just review the diff to make sure it accurately reflects the change made by your PR, then mark it "Ready for review". Then I will take care of the rest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants