Conversation
…on cause Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
40 tasks
Contributor
|
@stephanieelliott sorry to bother you, first time seeing one of these that I can remember... Should I just open it for your review? |
Contributor
|
No worries @carlosmiceli! You'd just review the diff to make sure it accurately reflects the change made by your PR, then mark it "Ready for review". Then I will take care of the rest! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for [Payment due @nyomanjyotisa] Fix personal card reconnection for error 434.
That PR makes the "account not found" scrape result actionable for personal cards: a personal card that fails with it now surfaces the broken connection error and the Fix card option on the Card details page, instead of silently stopping imports. In Expensify Classic this case is described to members as the account number having changed at the bank.
docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.mddocumented four causes of a broken personal card connection, none of which covered this one. This adds it:Your card number changed, or the account is no longer active at your bank.as a cause. Wording matches the existing company card article, which already describes this error as "Account not found / Card number changed".What should I do if my card number changed at the bank?, explaining that the card shows a red dot in Wallet, that the Card details page offers Fix card, and what to do if the account is closed for good.card number changedandaccount not foundtokeywordsso members searching those phrases land here.No other help site article needed a change. The existing steps under How to fix a broken personal card connection and the 90-day reminder behavior are unchanged by the code PR.
UI labels used here (Account, Wallet, Cards, Card details, Fix card, Update card, Time Sensitive) were verified against the current New Expensify web UI and
src/languages/en.ts.Fixed Issues
$ #101045
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Documentation-only change.
npm run spell-changedpasses on the edited article.Offline tests
N/A — help site content only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — help site content only.
Android: mWeb Chrome
N/A — help site content only.
iOS: Native
N/A — help site content only.
iOS: mWeb Safari
N/A — help site content only.
MacOS: Chrome / Safari
N/A — help site content only.
@carlosmiceli, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.