Skip to content

[No QA] Docs updates for E/A#100687 Broken company card feed reconnect flow - #101481

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-brokenCardFeedReconnect
Draft

[No QA] Docs updates for E/A#100687 Broken company card feed reconnect flow#101481
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-brokenCardFeedReconnect

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to Fix - Company cards - Broken card feed connection RHP spins forever with no error when the feed has a feed-level error, which changed three things a Workspace Admin can see. docs/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection.md documented none of them, and one existing step is now wrong for non-direct feeds.

1. The reconnect link only exists on direct feeds. The banner copy is now chosen by feed type — direct (OAuth/Plaid) feeds get workspace.companyCards.brokenConnectionError with the log into your bank link, everything else gets personalCard.brokenConnection ("Your card connection is broken.") with no link at all. Commercial and spreadsheet feeds still surface the banner when the feed itself has errors, so the article's old step 4 — "Select the error message under the card feed name and follow the prompts" — no longer works for them. Added a What to do when a company card feed can't be reconnected in Expensify section plus an FAQ entry, and scoped the fix steps to direct feeds.

2. There is a new error screen. A bank login that succeeds but whose account import fails now renders "Couldn't load this feed" with a Got it button instead of an endless spinner. Added it to the troubleshooting list with the exact heading, message, and button label.

3. The panel's open/close behavior changed. The reconnect now stays open through the bank login and closes itself when the reconnect completes; an assign-card flow that detoured into the reconnect no longer resumes afterwards and must be restarted. Documented both under What happens after you fix a company card connection and in a new FAQ entry.

No new article was needed — everything belongs to the existing broken-connection workflow, and splitting it would violate the one-workflow-per-article rule.

Labels verified against the live UI on web (Workspaces, Company cards) and against src/languages/en.ts for strings not reachable without a broken feed: brokenConnectionError, personalCard.brokenConnection, error.feedCouldNotBeLoadedTitle, common.genericErrorMessage, and common.buttonConfirm — which renders as Got it, not "Confirm".

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # title plus # FAQ, ## sections only, every section heading task-based, button and tab names bolded in sentence case, one cross-link.

Fixed Issues

$ #100465
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@jmusial, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

@MelvinBot @jmusial
Docs: document broken company card feed reconnect behavior changes
62c1035 
Follow-up to PR 100687. Scope the reconnect steps to direct feeds, add the
feeds that cannot be reconnected in Expensify, document the new
"Couldn't load this feed" error state, and describe the panel's new
open/close behavior.

Co-authored-by: jmusial <jmusial@users.noreply.github.com>
Co-authored-by: Jan Musiał <jmusial@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:34
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
@MelvinBot MelvinBot mentioned this pull request Sep 17, 2026
Merged
38 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#100687 Broken company card feed reconnect flow [No QA] Docs updates for E/A#100687 Broken company card feed reconnect flow Sep 17, 2026
@OSBotify

OSBotify commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://925a0ad8.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanieelliott stephanieelliott Awaiting requested review from stephanieelliott stephanieelliott will be requested when the pull request is marked ready for review stephanieelliott is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jmusial jmusial

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MelvinBot @OSBotify @jmusial