Conversation
…adsheet imports Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://b822dc73.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to [Payment due @abdulrahuman5196] Improve column auto-mapping when the file structure is different, which changed how the company card spreadsheet import pre-fills its field mappings.
Before that PR, each column auto-detected its own field independently and a saved layout from the previous upload was restored by column position, so re-importing a differently structured file could pre-select the same field on two columns or point a field at an unrelated column. Now the whole mapping is computed in one pass: the headers of the file you just uploaded come first, the saved layout is only a positional fallback for fields the headers don't identify, and it can never override a header match or repeat a field.
The article described the old behavior — "Previously mapped fields auto-fill to save time" — which no longer explains what an admin sees on the mapping screen, and it never documented that mappings are pre-filled from the file's column headers at all. This PR updates
docs/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet.mdto match:## How Expensify fills in your field mappingssection covering header-based detection, the one-column-per-field rule, the saved-layout fallback, and columns left on Ignore.## How to upload additional transactions to an existing card feed.## Can I change field mappings after importing transactions?FAQ and adds two FAQs for the questions this behavior raises: why fields arrive already filled in, and why a field mapped last time can come back empty.All field and button labels used (Card number, Card name, Date, Merchant, Amount, Currency, Unique ID, Ignore, Import, Add cards, Import transactions from file, Import spreadsheet) were verified against the strings the app renders in
src/languages/en.ts. A live-UI pass got as far as the Add cards button but couldn't reach the mapping screen — the add-cards flow requires an account-validation magic code, and file upload isn't drivable on the web test harness.Fixed Issues
$ #96654
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Gonals, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.