Conversation
Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Expense-Empty report can be downloaded via reconciliation in workspace chat (
Expensify/App#101048), which blocked exporting a report that has no expenses from a report's More > Export menu and from the basic CSV / Export current view export on the Reports page. Before that change, exporting an empty report produced an empty file from those entry points; now it shows Download failed with the message You can't export an empty report.The help site never documented this limitation, so members who hit the modal had nothing to search for. This PR adds one FAQ entry to How to Export Reports explaining why the export is blocked, the exact message shown, how to resolve it, and that a mixed selection of empty and non-empty reports still exports.
What changed
docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md— new FAQ section Why can't I export a report with no expenses?, plusexport empty reportanddownload failedadded tokeywordsso the modal text is searchable.No change is needed in How to Export Expenses: that article covers selecting expenses on the Expenses page, where the empty-report guard does not apply.
UI labels verified against the live app (web)
Every label used in the new copy was checked in a running NewDot build rather than taken from the source strings: the Spend > Reports navigation, the report header's More button, the Export item, the export template list, and the modal's title (Download failed), body (You can't export an empty report.), and button (Got it).
AI Tests
npx cspellcould not run in this environment (no network access to install the package). The added copy uses only words already present in the article.docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md: one#title plus# FAQ,##only, question-word heading, bolded UI labels in exact UI casing, no quotation marks around labels.Fixed Issues
$
PROPOSAL:
Docs follow-up for #101048 — no separate issue.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.