Conversation
…ite step Co-authored-by: Marcin Warchoł <war-in@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for feat: Replace vacation delegate policy diff warning with RHP invite step, which replaced the blocking "policy diff" warning with an RHP step (
VacationDelegateMissingWorkspacesPage).docs/articles/new-expensify/settings/Delegate-when-out-of-office.mddescribed the old behavior only — its FAQ said that when a delegate isn't part of your workspace, "Workspace Admins will be notified by email and prompted to add them," with no mention that you can now invite the delegate yourself. That answer is now incomplete and misleading, so the article needed an update.What changed in the article:
## How to invite a Vacation delegate who is missing from a workspace, covering the new step: the two workspace groups (You are an admin of these workspaces: and You are a member of these workspaces:), the three possible button sets (Invite / Skip, or Confirm alone when you administer none of the listed workspaces), and the fact that leaving the page without choosing one leaves your delegate unchanged.Does skipping the invite still save my delegate?entry.docs/HELP_AUTHORING_GUIDELINES.md: single#title plus# FAQ, task-based##headings, added the requiredinternalScopemetadata, and used the UI-exact label Vacation delegate (lowercase "delegate") perdocs/HELPSITE_NAMING_CONVENTIONS.md.Every UI label in the article was verified against a live dev NewDot web session rather than taken from the source strings alone: the Account > Profile > Status path, the Vacation delegate row, the Name, email, or phone number field, the You are an admin of these workspaces: heading, and the Invite / Skip buttons. The absence of any confirmation prompt on removal was also confirmed live.
No other article needed changes.
docs/articles/expensify-classic/copilots-and-delegates/Delegate-when-out-of-office.mddocuments Expensify Classic, which this PR does not touch, and the cross-link inManage-Copilot-Access.mdstill resolves.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this PR only changes help site markdown.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@war-in, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.