Conversation
Co-authored-by: Cong Pham <suneox@users.noreply.github.com>
40 tasks
This comment has been minimized.
This comment has been minimized.
HELP_AUTHORING_GUIDELINES.md 3 and 6 require metadata to reflect real search queries, so both articles now carry who-can-edit keywords. HELPSITE_NAMING_CONVENTIONS.md requires the exact UI capitalization, and en.ts renders the status as Unreported. Co-authored-by: Cong Pham <suneox@users.noreply.github.com>
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://715ef3e3.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Only let policy admins and managers edit expenses on expense reports, which stopped a non-owner from editing an unreported expense (a self-DM tracked expense) just because they admin their own workspace.
The help site never documented the buggy behavior, so nothing here is a correction. What it did have was a gap:
Edit Expenseslisted edit rights only for members, the current approver, and Workspace Admins on Draft and Outstanding reports, and said nothing about who can edit an expense that isn't on a report yet. That gap is exactly what the linked bug report was about, so this PR fills it.Two articles change, 7 lines added, no lines removed or reworded:
docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.md— adds anExpense creator onlybullet to the existingWho can edit expenseslist, plus one sentence explaining that approver and Workspace Admin rights come from the report the expense sits on, so they don't reach an unreported expense.docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md— adds a## Can someone else edit an expense I tracked?FAQ entry next to the existing## Can I edit an expense after tracking it?entry, and cross-links back toEdit Expenses.Conventions applied:
# FAQsection, so the one-#-per-article rule indocs/HELP_AUTHORING_GUIDELINES.md§4 still holds. The new FAQ heading is a full question, per §2.Fixed Issues
$
PROPOSAL:
Docs-only follow-up, so there is no separate issue to link. Source PR: #101029
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR only changes markdown under
docs/articles, so there is no app behavior to exercise. Reviewing it means confirming the copy matches the behavior shipped in #101029: a member other than the expense creator sees every field on an unreported expense as read-only, while the creator keeps full edit rights.Offline tests
Not applicable. This PR changes help site markdown only and ships no client code, so there is no offline behavior to verify.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@suneox, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.