Skip to content

[No QA] Docs updates for E/A#101029 clarify who can edit unreported expenses - #101492

Draft
MelvinBot wants to merge 2 commits into
mainfrom
claude-docsUnreportedExpenseEditPermissions
Draft

MelvinBot wants to merge 2 commits into
mainfrom
claude-docsUnreportedExpenseEditPermissions

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Only let policy admins and managers edit expenses on expense reports, which stopped a non-owner from editing an unreported expense (a self-DM tracked expense) just because they admin their own workspace.

The help site never documented the buggy behavior, so nothing here is a correction. What it did have was a gap: Edit Expenses listed edit rights only for members, the current approver, and Workspace Admins on Draft and Outstanding reports, and said nothing about who can edit an expense that isn't on a report yet. That gap is exactly what the linked bug report was about, so this PR fills it.

Two articles change, 7 lines added, no lines removed or reworded:

  • docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.md — adds an Expense creator only bullet to the existing Who can edit expenses list, plus one sentence explaining that approver and Workspace Admin rights come from the report the expense sits on, so they don't reach an unreported expense.
  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md — adds a ## Can someone else edit an expense I tracked? FAQ entry next to the existing ## Can I edit an expense after tracking it? entry, and cross-links back to Edit Expenses.

Conventions applied:

  • No new headings outside the existing # FAQ section, so the one-#-per-article rule in docs/HELP_AUTHORING_GUIDELINES.md §4 still holds. The new FAQ heading is a full question, per §2.
  • The cross-link uses descriptive anchor text ("Learn who can edit expenses") per §7, and points at a prerequisite explanation rather than a tangential article.
  • UI labels were verified against a live NewDot session on web before writing. The left-hand navigation tab is Spend with an Expenses sub-tab, which matches what both articles already say. Worth noting for review: on a self-DM tracked expense with no workspace tags configured, the rows shown are Amount, Description, Merchant, Date, Category, Reimbursable, and Report — there is no Tag or Billable row in that case. The new copy therefore says "every field" instead of naming individual rows, so it stays accurate whether or not a default workspace supplies Tag and Billable.

Fixed Issues

$
PROPOSAL:

Docs-only follow-up, so there is no separate issue to link. Source PR: #101029

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

This PR only changes markdown under docs/articles, so there is no app behavior to exercise. Reviewing it means confirming the copy matches the behavior shipped in #101029: a member other than the expense creator sees every field on an unreported expense as read-only, while the creator keeps full edit rights.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR changes help site markdown only and ships no client code, so there is no offline behavior to verify.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@suneox, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Cong Pham <suneox@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:41
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#101029 clarify who can edit unreported expenses [No QA] Docs updates for E/A#101029 clarify who can edit unreported expenses Sep 17, 2026
@OSBotify

This comment has been minimized.

HELP_AUTHORING_GUIDELINES.md 3 and 6 require metadata to reflect real search queries, so both articles now carry who-can-edit keywords. HELPSITE_NAMING_CONVENTIONS.md requires the exact UI capitalization, and en.ts renders the status as Unreported.

Co-authored-by: Cong Pham <suneox@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://715ef3e3.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants