Conversation
Co-authored-by: Olly <Ollyws@users.noreply.github.com>
58 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://b1bdbbdc.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Show New message marker when a user marks their own message as unread, which fixed the green New line not appearing when a member marks their own message as unread.
No existing article was made inaccurate by that PR — the Mark as unread / Mark as read message and chat actions were never documented on the help site at all. This PR adds a single new article covering that workflow:
docs/articles/new-expensify/chat/Mark-a-Chat-or-Message-as-Unread.mdIt documents:
Labels and feature names were taken from the product source rather than paraphrased:
reportActionContextMenu.markAsUnread= Mark as unread,reportActionContextMenu.markAsRead= Mark as read, and the marker itself renderscommon.new= New. The Unread tab name matches the existing Navigating New Expensify article.Authored against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one workflow, a single#title plus# FAQ, task-based##headings only, YAML metadata withinternalScope, bolded UI labels, separate Web/Mobile steps, one screenshot placeholder with a stated purpose, and one relative cross-link../.github/scripts/createDocsRoutes.shpasses, so no_routes.ymlchange is needed.One item needs your confirmation before this ships: the FAQ answer "Why is the green New line gone when you return to a chat?" states that leaving the chat and coming back, or reloading, clears the line. That matches the merged code (
openReportclearsmanuallyMarkedUnreadReportActionIDon a return trip or a cold start), but I could not verify it in a live session — the per-message hover menu never mounted in the headless web test environment, so the action could not be triggered. Please confirm or correct that answer.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only, no app code is changed.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Ollyws, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.