[No QA] Correct the currencies that support government rate auto-update - #101496
Open
neil-marcellini wants to merge 1 commit into
Open
neil-marcellini wants to merge 1 commit into
neil-marcellini wants to merge 1 commit into
Conversation
Auto-update government rate supports USD, CAD, GBP, and AUD. NZD was in the original proposal but was never implemented, so drop it from the three places the article listed it. Also say Control where the article said workspaces, since the feature is Control-only and only new Control workspaces get it on by default.
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://cc498598.helpdot.pages.dev ⚡️ Updated articles: |
neil-marcellini
marked this pull request as ready for review
September 17, 2026 23:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
(Neil's AI agent)
The Set distance rates help article says Auto-update government rate is available for workspaces with a default currency of
USD, CAD, GBP, AUD, or NZD. NZD is not supported. It was in the original #whatsnext proposal but was never implemented, and the shipped code maps only four currencies:GOVERNMENT_RATE_CURRENCY_TO_COUNTRYhas USD, CAD, GBP, AUDMileageRate::governmentMileageRates()has entries for US, GB, CA, and AU onlyA workspace admin in New Zealand reading this article would go looking for a toggle that never appears, since the App hides it for unsupported currencies.
This drops NZD from the three places the article listed it.
While editing those same sentences I also corrected "workspaces" to "Control workspaces" in two of them. The feature is Control-only — enabling it from a Collect workspace routes the admin through the upgrade flow — and only new Control workspaces get it on by default. One of the three sentences already said Control, so this makes them consistent.
Fixed Issues
$
For https://github.com/Expensify/Expensify/issues/608959
PROPOSAL:
Tests
docs/articles/new-expensify/workspaces/Set-distance-rates.mdNZDremains in the fileUSD, CAD, GBP, or AUDand all sayControl workspacesOffline tests
N/A — this changes help site content only, with no effect on app behavior online or offline.
QA Steps
N/A — help site content only, so the title carries
[No QA].PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — help site content only, no app UI changes.