Skip to content

[No QA] Correct the currencies that support government rate auto-update - #101496

Open
neil-marcellini wants to merge 1 commit into
mainfrom
neil-marcellini/fix-government-rate-currency-docs
Open

neil-marcellini wants to merge 1 commit into
mainfrom
neil-marcellini/fix-government-rate-currency-docs

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

(Neil's AI agent)

The Set distance rates help article says Auto-update government rate is available for workspaces with a default currency of USD, CAD, GBP, AUD, or NZD. NZD is not supported. It was in the original #whatsnext proposal but was never implemented, and the shipped code maps only four currencies:

A workspace admin in New Zealand reading this article would go looking for a toggle that never appears, since the App hides it for unsupported currencies.

This drops NZD from the three places the article listed it.

While editing those same sentences I also corrected "workspaces" to "Control workspaces" in two of them. The feature is Control-only — enabling it from a Collect workspace routes the admin through the upgrade flow — and only new Control workspaces get it on by default. One of the three sentences already said Control, so this makes them consistent.

Fixed Issues

$
For https://github.com/Expensify/Expensify/issues/608959

PROPOSAL:

Tests

  1. Open docs/articles/new-expensify/workspaces/Set-distance-rates.md
  2. Verify no occurrence of NZD remains in the file
  3. Verify the three sentences describing which currencies support automatic updates all read USD, CAD, GBP, or AUD and all say Control workspaces
  4. Create a workspace on the Control plan with a default currency of NZD and go to Workspace > Distance rates > Settings
  5. Verify the Auto-update government rate toggle is not shown, confirming the article's previous claim was wrong
  6. Change the workspace default currency to AUD
  7. Verify the Auto-update government rate toggle now appears, confirming AUD is supported as the article states

Offline tests

N/A — this changes help site content only, with no effect on app behavior online or offline.

QA Steps

N/A — help site content only, so the title carries [No QA].

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — help site content only, no app UI changes.

Auto-update government rate supports USD, CAD, GBP, and AUD. NZD was in
the original proposal but was never implemented, so drop it from the
three places the article listed it.

Also say Control where the article said workspaces, since the feature is
Control-only and only new Control workspaces get it on by default.
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://cc498598.helpdot.pages.dev ⚡️

Updated articles:

@neil-marcellini
neil-marcellini marked this pull request as ready for review September 17, 2026 23:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T23:41:59.808649Z 5cd360e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants