[CP Staging] Fix AttachmentCamera UI rotation in landscape - #101526
Conversation
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@huult This is ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-18.at.21.11.46.mp4 |
|
@ShridharGoel #101499 We’ll fix this ticket in another PR, right? |
Had thought that initially, but I think we should do in this PR itself |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@huult Did you get a chance to review? |
|
I’ll continue reviewing it in the next hour. |
|
Reviewing... |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP Staging] Fix AttachmentCamera UI rotation in landscape (cherry picked from commit 472c858) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.85-1 🚀
|
|
🤖 No help site changes are required for this PR — no draft docs PR was created. This change is a layout-only fix: it switches the What I checked in
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.86-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.89-0 🚀
|
|
🤖 Re-checked — still no help site changes required. No draft docs PR was created. The merged diff is unchanged since my earlier review: the same three files ( What the PR actually changes, and why the docs are unaffected
The only article covering this flow is docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md:22, which says only: "To add an attachment, click the plus icon and select Add attachment." It never describes the camera screen's control positions or device orientation, so it stays correct. I also swept the docs for
The help site documents what users can do, not per-orientation screen layout, so there is nothing to update. Because no docs change is needed, there is no help site PR to link, label @ShridharGoel, please confirm you agree that no help site update is needed. If you think an article should call out the landscape camera layout, reply with |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.90-0 🚀
|
Explanation of Change
Adapts the
AttachmentCameraUI when rotating to landscape mode to follow the pattern used inIOURequestStepScan(receipt scanning camera):styles.flexRow) in landscape mode so the camera viewfinder remains on the left while controls stay on the right.!isLandscape && styles.flexRow), preventing UI controls from rotating awkwardly across the bottom in landscape.ScrollViewwithstyles.permissionViewLandscapewhen in landscape mode to prevent content cutoff and allow scrolling.Related to #96458
Fixed Issues
$ #101518
Tests
+->Add attachment->Take photo.Take photoin landscape mode, and verify the permission prompt is scrollable and readable.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-18.at.1.20.25.PM.mov