Conversation
Co-authored-by: Olly <Ollyws@users.noreply.github.com>
58 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://5c2a825d.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Show New message marker when a user marks their own message as unread (
Expensify/App#95217), which $ The green "New" marker is not shown when marking your own message as unread (Expensify/App#94794).That PR changed user-visible behavior: marking your own message as unread now anchors the green New marker above it, the marker stays put while you remain in the chat, and a message you just sent still never gets the marker. It also added
manuallyMarkedUnreadReportActionIDso the marker anchors to the marked message by ID and relocates if that message is deleted.Mark as unread, Mark as read, and the New marker had no coverage anywhere on the help site —
grep -ril "mark as unread" docs/articles/returned nothing. So rather than correcting a stale article, this adds the missing one.What this PR does:
docs/articles/new-expensify/chat/Mark-a-Chat-or-Message-as-Unread.md, covering how to mark an individual message as unread, how to mark a whole chat as unread or read, what the New marker shows, and how long it stays.docs/_data/_routes.yml.Why a new article instead of extending
Chat-Features-and-Moderation-Tools.md:docs/HELP_AUTHORING_GUIDELINES.mdSection 1 requires one primary workflow per article and says to split when multiple are detected. That article already covers sending, formatting, editing, deleting, reporting, and membership, so adding a sixth workflow would compound the existing violation.UI labels verified against source (I could not verify them against the running app — see the note below), so every label in the article is the exact product string:
src/languages/en.ts:874src/languages/en.ts:875src/languages/en.ts:84, rendered bysrc/components/UnreadActionIndicator.tsx:30Behavioral claims are sourced the same way:
ContextMenuActions.tsx:544-546.ContextMenuActions.tsx:624.useMarkAsRead.ts:178../.github/scripts/createDocsRoutes.sh(the checkvalidateDocsRoutes.ymlruns) passes.Important
I could not verify this against the running app. I asked a web tester to walk the flow, but the message context menu could not be opened in the headless session: right-click returned
UNSUPPORTED_OPERATION, long-press is unsupported on web, and hover was accepted but never triggered the app's hover state. Everything above is read from source, not observed. The claim most worth a human check is how long the marker survives: PRExpensify/App#95217's own test steps say the marker is still shown after navigating away and back, but the merged code clearsmanuallyMarkedUnreadReportActionIDon the return trip and on refresh, and opening the chat marks it read. I wrote the article to match the merged code. If the marker really does persist across a return trip, the "How long the New marker stays on a message" section needs to change.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
Offline tests
N/A — documentation-only change. No app code is touched.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — documentation-only change. The article includes two
<!-- SCREENSHOT: -->placeholders perdocs/HELP_AUTHORING_GUIDELINES.mdSection 8, for the context menu showing Mark as unread and for the New marker in a chat.@Ollyws, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.