[No QA] Consolidated help docs: new-expensify/connect-credit-cards - #101953
stephanieelliott wants to merge 8 commits into
Conversation
…ect-credit-cards
…ect-credit-cards
…nect-credit-cards
…nect-credit-cards
…nect-credit-cards
…nect-credit-cards
…nect-credit-cards
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ## How to configure settings for company card feeds | ||
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile) navigate to **Workspaces > [Workspace Name]**. | ||
| 2. Select **Company Cards** and chose the relevant company card feed. |
There was a problem hiding this comment.
UI label casing + typo: The UI label is Company cards (lowercase "c"), used consistently everywhere else in this PR — match capitalization exactly (HELPSITE_NAMING_CONVENTIONS.md, Core UI Referencing Rules). Also, "chose" should be "choose".
| 2. Select **Company Cards** and chose the relevant company card feed. | |
| 2. Select **Company cards** and choose the relevant company card feed. |
| 6. Enter a name for the card feed. | ||
| 7. Review the field mappings, which Expensify fills in from your file's column headers, and set any that are still **Ignore**. You must map either a **Card number** or a **Card name**, along with **Date**, **Merchant**, **Amount**, and **Currency**. | ||
| 8. Map **Unique ID** to a column that holds a unique reference for each transaction, if your file has one. | ||
| 9. Assign cards to users based on the transactions in the file. |
There was a problem hiding this comment.
Terminology violation: Use "members" instead of "users" to match Expensify standards (HELP_AUTHORING_GUIDELINES.md). Note the consolidated companion doc already uses "workspace members" for this same sentence.
| 9. Assign cards to users based on the transactions in the file. | |
| 9. Assign cards to members based on the transactions in the file. |
|
|
||
| ## How does matching transactions by card name work? | ||
|
|
||
| Instead of a **Card number**, you can map a **Card name** column, and Expensify groups each transaction under the card identified by that name. After you upload the file, those cards appear as entries you can assign to users — the name doesn't need to match a card you've already assigned. You only need one card-identity column, so map a **Card number** column instead if you'd rather identify cards by number. |
There was a problem hiding this comment.
Terminology violation: "assign to users" should be "assign to members" to match Expensify terminology (HELP_AUTHORING_GUIDELINES.md). The companion doc in this PR uses "assign to workspace members" for the identical sentence.
|
|
||
| These reminders appear while the connection has recently broken. If a personal card has gone 90 days or more without a successful sync, the **Time Sensitive** notification on **Home** and the red dot on **Wallet** in the navigation tabs stop showing. The card still appears in **Wallet** with its red dot, and you can select it and choose **Fix card** to restore the connection at any time. | ||
|
|
||
| <!-- SCREENSHOT: |
There was a problem hiding this comment.
Screenshot placeholder format violation: The `` block must use the exact required fields Suggestion:, `Location:`, and `Purpose:` (HELP_AUTHORING_GUIDELINES.md Section 8). This block is missing `Location:` and `Purpose:` and instead includes a non-standard `Design request:` field. The `Purpose:` must explain the specific member confusion the screenshot resolves.
|
|
||
| ## How do I fix a broken company card feed connection? | ||
|
|
||
| If your company card feed is broken, you can fix it from the **Time sensitive** section on **Home**. Click **Fix** to restore the connection. [Learn how to fix a broken company card feed connection](/articles/new-expensify/connect-credit-cards/Fix-a-broken-Company-Card-Feed-Connection). |
There was a problem hiding this comment.
Broken relative link + UI label casing: The link path Fix-a-broken-Company-Card-Feed-Connection uses a lowercase "b" but the actual file added in this PR is Fix-a-Broken-Company-Card-Feed-Connection.md (capital "B") — this link will 404. Also, the section label is Time Sensitive (capital "S"), used consistently elsewhere; "Time sensitive" here breaks exact UI-label casing (HELPSITE_NAMING_CONVENTIONS.md).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6620132b91
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## What the 30-day broken personal card connection reminder means | ||
|
|
||
| If a personal card connection is still broken 30 days after it first stopped working, Concierge sends you a follow-up message in your Concierge chat. The message names the card and gives you two choices: |
There was a problem hiding this comment.
This entire new article, including the 30-day reminder, is unreachable in production: docs/redirects.csv:978 already redirects /articles/new-expensify/connect-credit-cards/Manage-Personal-Cards to the nested canonical article, and .github/scripts/createHelpRedirects.sh installs these sources as Cloudflare bulk redirects. The same collision affects the newly added direct-feed, spreadsheet-import, and company-card-settings articles via redirect lines 972, 974, and 976. Move the new content into the canonical nested files or deliberately remove the redirects; otherwise the generated hub entries send readers to the older articles instead of displaying these changes.
Useful? React with 👍 / 👎.
|
|
||
| ## How to fix a broken company card connection | ||
|
|
||
| If your direct (bank-connected or Plaid) company card feed stops working, a Workspace Admin can reconnect it from the workspace. |
There was a problem hiding this comment.
On Control workspaces, Card Admins can also reconnect a broken company-card feed: src/libs/PolicyUtils.ts grants CARD_ADMIN write access to COMPANY_CARDS, and BrokenCardFeedConnectionPage.tsx gates the flow on that write permission rather than the workspace-admin role. Describing the action as available only to a Workspace Admin incorrectly sends affected Card Admins away from a flow they are authorized to complete.
Useful? React with 👍 / 👎.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@amyevans @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This branch has not been deployed
2 participants
Summary
Consolidates 7 help doc PRs for
new-expensify/connect-credit-cardsinto a single reviewable PR.Included PRs
Test plan