feat: Add tsgo for faster dev type checking #83228
Draft
dariusz-biela wants to merge 10 commits intoExpensify:mainfrom
Draft
feat: Add tsgo for faster dev type checking #83228dariusz-biela wants to merge 10 commits intoExpensify:mainfrom
dariusz-biela wants to merge 10 commits intoExpensify:mainfrom
Conversation
Install @typescript/native-preview and configure `npm run typecheck-tsgo` with a dedicated tsconfig.tsgo.json. Enables the experimental Go-based TypeScript compiler for faster type checking during development.
… assignment in IOU
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add
@typescript/native-preview(tsgo) as a dev dependency withnpm run typecheck-tsgocommand for faster type checking during development. Includes a dedicatedtsconfig.tsgo.jsonand fixes for existing type errors detected by tsgo.Benchmark (Expensify App):
Bugs fixed (detected by tsgo, silently accepted by tsc):
Remove duplicate
VERIFY_3DS_SUBSCRIPTIONkey inOnyxValuesMappingRemove duplicate command keys in
API/types.tsAdd null check for
regexResult.indices[0]inEmojiUtilsRemove duplicate
EXPENSIFY_CARDscreen params inNavigation/types.tsRemove unnecessary
@ts-expect-errordirectives and fixstatusNumassignment inIOU/index.tsRestructure conditional
OnyxUpdatespread to avoidundefinedinPolicy.tsRemove duplicate CORPAY field definitions in
ReimbursementAccount.tsType lazy SVG import catch handlers in
BackgroundImage/index.tsxImport
ListRenderItemInfofrom main@react-native/virtualized-listsexportFixed Issues
Tests
N/A — dev tooling only, no runtime changes.
Offline tests
N/A
QA Steps
N/A — no user-facing changes. [No QA]
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.