[Odometer] Image capture for mWeb

[jakubkalinski0]

Explanation of Change

This PR implements the next part of the Odometer feature, aligned with Phase 1 task 1.D. This PR focuses on the mWeb implementation of the image capture flow.

• 1.D (Capture start/end images) - added a complete implementation of src/pages/iou/request/step/IOURequestStepOdometerImage/index.tsx. We intentionally did not reuse IOURequestStepScan because that screen includes receipt‑specific behaviors (SmartScan, receipt state logic). The implementation covers all the following aspects:
  • Camera permissions logic,
  • Flash logic,
  • Photo/file picker,
  • Taking the photo and saving it.

Due to duplicated logic across IOURequestStepOdometerImage and IOURequestStepScan there is a plan to introduce more abstraction for the camera related logic/features in a followup once the Odometer project is done.

Fixed Issues

$ #77266
PROPOSAL: N/A

Tests

Important

• iOS simulator doesn't support camera functionality so if you want to test it you have to use a physical device
• If you want to test functionality of flash you also need to use a physical device as you cannot actually observe if it works

Caution

Use Android emulator or a physical device for testing - explanation above ^

Prerequisites:
Turn off camera permissions for Expensify -> the most convenient for you would probably be to set "Ask every time"

1. Press FAB -> go to "Track distance" -> choose "Odometer" tab`
2. Press on the Thumbnail -> you should see the screen shown below

3. Press "Continue" -> verify that you are shown a native prompt asking you to allow Expensify to use the camera

4. Press "Only this time" (pressing "While using this app" would behave the same but will require you to turn off camera permissions for Expensify once again later) -> verify that you now have access to the came (the screen from step 2 is gone and you see a working camera display like the one below)

Important

If your device has no back camera then you will see a following screen (same behavior as in the scan component)

Important

If your device has no flash then the Bolt icon of flash in the top right corner will be hidden - in order to test the flash itself you have to do it on a physical device

5. Take the photo -> verify that the camera is closed and you are brought back to the Odometer page with the photo you have just taken being displayed correctly in the thumbnail

6. Verify that when you press on the thumbnail once again then you are brought to the Image Preview and it displays the photo correctly
7. Then press on the Three dots menu and verify that when you press "Replace" then you are brought to the Camera photo capture and that it works correctly
8. Now rebuild the app in order to reset the permissions (or turn them off once again if you chose "While using this app" earlier)
9. Repeat the steps 1 through 3 but now press "Don't allow" when asked about camera permissions -> verify that you are shown this screen with further instructions

10. Now press the highlighted link "these instructions" and verify that you are brought to this "help.expensify" page

11. Now follow the instructions from the "help.expensify", i.e. change your browser camera permissions accordingly and refresh the App page

12. After the page reload from the previous step you should the Camera photo capture -> verify that it works properly

13. Now Press the Gallery icon at the bottom left corner and verify that all the options work properly

Important

Proper functionality for Camera Camcorder when you try to submit a video is to show the following prompt as we do not allow videos for Odometer Image (same behavior as Scan)

15. (optional, but recommended) Now repeat the steps 1 through 13 for End odometer photo (although if everything worked properly for Start photo then it will work the same for the End photo)
    • (Noticeable difference) The information box at the bottom of the camera field should display information (i.e. icon/text) about the End odometer photo

Warning

When testing End odometer photo after the Start odometer phot" your camera permissions for Expensify were probably set to "Don't allow" after the step 9 so you will have to change it to "Ask every time" when testing the second photo flow

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: mWeb Chrome

iOS: mWeb Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...request/step/IOURequestStepOdometerImage/index.tsx	0.00% <0.00%> (ø)
... and 42 files with indirect coverage changes

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main