Remove decimals: 0 override for COP in test data#83296
Draft
Remove decimals: 0 override for COP in test data#83296
Conversation
COP (Colombian Peso) was configured with decimals: 0 which prevented decimal input in New Expensify. Remove this override so the default of 2 decimals is used, matching the updated backend configuration. Fixes #81582 Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Remove the
"decimals": 0override for COP (Colombian Peso) from the test currency list data. Whendecimalsis absent, the default of 2 is used, which matches the updated backend configuration (PHP-Libs PR already deployed). This keeps the test data in sync with the backend source of truth.Note: The
Mobile-Expensify/app/defaultConstants.jsonfile also needs the same change (item 5 from the proposal), but Mobile-Expensify is a private submodule that I don't have access to. That change will need to be made separately.Fixed Issues
$ #81582
PROPOSAL: #81582 (comment)
Tests
npx jest tests/unit/CurrencyUtilsTest)decimals: 0intests/unit/currencyList.jsonOffline tests
N/A — This is a test data change only. The live behavior in New Expensify is driven by the currency list fetched from the API (PHP-Libs), which has already been updated.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — test data change only
Android: mWeb Chrome
N/A — test data change only
iOS: Native
N/A — test data change only
iOS: mWeb Safari
N/A — test data change only
MacOS: Chrome / Safari
N/A — test data change only