migrate POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT#89510
migrate POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT#89510huult wants to merge 3 commits intoExpensify:mainfrom
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9276b9d039
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]} | ||
| policyID={policyID} | ||
| onBackButtonPress={goBack} | ||
| onBackButtonPress={() => Navigation.goBack(backPath)} |
There was a problem hiding this comment.
Preserve company-card back redirect for unsupported export mode
When this screen is opened from workspaces/:policyID/company-cards/:feed/:cardID/edit/export, the new onBackButtonPress={() => Navigation.goBack(backPath)} always returns to that .../edit/export route. That regresses the previous safeguard (goBackFromExportConnection) that redirected straight to card details when Sage Intacct reimbursable is EXPENSE_REPORT (an unsupported company-card export mode). In that state, users are sent back to an export-edit screen that no longer has a valid export option, instead of the intended card details page.
Useful? React with 👍 / 👎.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…Y_ACCOUNTING_SAGE_INTACCT_EXPORT
|
@mananjadhav This PR is ready for review. |
Explanation of Change
Fixed Issues
$ #83866
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT
Precondition: The workspace is connected to Sage Intacct.
Precondition: The workspace is connected to Sage Intacct, and a company card is assigned.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-05.at.11.51.53.mov