Skip to content

Fix amount column misalignment on Report details page by passing shouldRemoveTotalColumnFlex to TOTAL column #89515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Krishna2323 wants to merge 2 commits into from
Closed

Fix amount column misalignment on Report details page by passing shouldRemoveTotalColumnFlex to TOTAL column #89515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1f5d3
Fix amount column misalignment on Report details page by passing shou…
Krishna2323 May 4, 2026
a87ca1d
Fix items rendering in narrow layout when header shows columns in hor…
Krishna2323 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ type MoneyRequestReportTransactionItemProps = {

/** Whether this is the last item in the list */
isLastItem?: boolean;

/** Whether the list is horizontally scrollable */
shouldScrollHorizontally?: boolean;
};

function MoneyRequestReportTransactionItem({
Expand All @@ -93,6 +96,7 @@ function MoneyRequestReportTransactionItem({
shouldBeHighlighted,
nonPersonalAndWorkspaceCards,
isLastItem = false,
shouldScrollHorizontally = false,
}: MoneyRequestReportTransactionItemProps) {
const {translate} = useLocalize();
const styles = useThemeStyles();
Expand Down Expand Up @@ -164,7 +168,7 @@ function MoneyRequestReportTransactionItem({
amountColumnSize={amountColumnSize}
taxAmountColumnSize={taxAmountColumnSize}
shouldShowTooltip
shouldUseNarrowLayout={shouldUseNarrowLayout || isMediumScreenWidth}
shouldUseNarrowLayout={shouldUseNarrowLayout || (isMediumScreenWidth && !shouldScrollHorizontally)}
shouldShowCheckbox={!!isSelectionModeEnabled || !isSmallScreenWidth}
onCheckboxPress={toggleTransaction}
columns={columns}
Expand Down
1 change: 1 addition & 0 deletions src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ function MoneyRequestReportTransactionList({
onArrowRightPress={handleArrowRightPress}
nonPersonalAndWorkspaceCards={nonPersonalAndWorkspaceCards ?? {}}
isLastItem={!showPendingExpensePlaceholder && transaction.transactionID === lastTransactionID}
shouldScrollHorizontally={shouldScrollHorizontally}
/>
);

Expand Down
2 changes: 1 addition & 1 deletion src/components/TransactionItemRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ function TransactionItemRow({
return (
<View
key={column}
style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT, {isAmountColumnWide})]}
style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT, {isAmountColumnWide, shouldRemoveTotalColumnFlex})]}
>
<AmountCell
total={totalAmount}
Expand Down
Loading