Update currency help link to Enable Global Reimbursement article#89568
Draft
Update currency help link to Enable Global Reimbursement article#89568
Conversation
Rename CONNECT_A_BUSINESS_BANK_ACCOUNT_HELP_URL to ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL and update the URL to point to the Enable Global Reimbursement help article, which actually lists supported currencies. The old link pointed to the Connect a Business Bank Account article which does not contain currency information. Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
7 tasks
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 9bf1762b..b09db590 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6457,7 +6457,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
updateToUSD: 'Auf USD aktualisieren',
updateWorkspaceCurrency: 'Arbeitsbereichswährung aktualisieren',
workspaceCurrencyNotSupported: 'Workspace-Währung wird nicht unterstützt',
- yourWorkspace: `Dein Arbeitsbereich ist auf eine nicht unterstützte Währung eingestellt. Sieh dir die <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">Liste der unterstützten Währungen</a> an.`,
+ yourWorkspace: `Ihr Arbeitsbereich ist auf eine nicht unterstützte Währung eingestellt. Zeigen Sie die <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">Liste der unterstützten Währungen</a> an.`,
chooseAnExisting: 'Wähle ein bestehendes Bankkonto zum Bezahlen von Ausgaben oder füge ein neues hinzu.',
},
changeOwner: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b92ec8ca..a7ec55fc 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -6479,7 +6479,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
updateToUSD: 'Mettre à jour en USD',
updateWorkspaceCurrency: 'Mettre à jour la devise de l’espace de travail',
workspaceCurrencyNotSupported: "Devise de l'espace de travail non prise en charge",
- yourWorkspace: `Votre espace de travail est défini sur une devise non prise en charge. Consultez la <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">liste des devises prises en charge</a>.`,
+ yourWorkspace: `Votre espace de travail est configuré sur une devise non prise en charge. Consultez la <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">liste des devises prises en charge</a>.`,
chooseAnExisting: 'Choisissez un compte bancaire existant pour payer les dépenses ou ajoutez-en un nouveau.',
},
changeOwner: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index dd6d2082..48968527 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6442,7 +6442,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
updateToUSD: 'Aggiorna a USD',
updateWorkspaceCurrency: 'Aggiorna la valuta dello spazio di lavoro',
workspaceCurrencyNotSupported: 'Valuta dello spazio di lavoro non supportata',
- yourWorkspace: `La tua area di lavoro è impostata su una valuta non supportata. Visualizza l’<a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">elenco delle valute supportate</a>.`,
+ yourWorkspace: `Lo spazio di lavoro è impostato su una valuta non supportata. Visualizza l’<a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">elenco delle valute supportate</a>.`,
chooseAnExisting: 'Scegli un conto bancario esistente per pagare le spese oppure aggiungine uno nuovo.',
},
changeOwner: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 26c1bc8c..71631812 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6372,7 +6372,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
updateToUSD: 'USD に更新',
updateWorkspaceCurrency: 'ワークスペースの通貨を更新',
workspaceCurrencyNotSupported: 'ワークスペースの通貨はサポートされていません',
- yourWorkspace: `ご利用のワークスペースはサポートされていない通貨に設定されています。<a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">サポートされている通貨の一覧</a>を表示します。`,
+ yourWorkspace: `ご利用のワークスペースは未対応の通貨に設定されています。<a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">対応している通貨の一覧</a>を表示します。`,
chooseAnExisting: '既存の銀行口座を選択して経費を支払うか、新しい口座を追加してください。',
},
changeOwner: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 9aacd650..f2ed0a2d 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6424,7 +6424,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
updateToUSD: 'Bijwerken naar USD',
updateWorkspaceCurrency: 'Werkruimtevaluta bijwerken',
workspaceCurrencyNotSupported: 'Werkruimtevaluta wordt niet ondersteund',
- yourWorkspace: `Je werkruimte is ingesteld op een niet-ondersteunde valuta. Bekijk de <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">lijst met ondersteunde valuta's</a>.`,
+ yourWorkspace: `Je werkruimte is ingesteld op een niet-ondersteunde valuta. Bekijk de <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">lijst met ondersteunde valuta’s</a>.`,
chooseAnExisting: 'Kies een bestaande bankrekening om onkosten te betalen of voeg een nieuwe toe.',
},
changeOwner: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 2bdec2ba..0e2f1abf 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6414,7 +6414,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
updateToUSD: 'Zaktualizuj na USD',
updateWorkspaceCurrency: 'Zaktualizuj walutę przestrzeni roboczej',
workspaceCurrencyNotSupported: 'Waluta przestrzeni roboczej nie jest obsługiwana',
- yourWorkspace: `Twoje miejsce pracy jest ustawione na nieobsługiwaną walutę. Zobacz <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">listę obsługiwanych walut</a>.`,
+ yourWorkspace: `W Twoim obszarze roboczym ustawiono nieobsługiwaną walutę. Zobacz <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">listę obsługiwanych walut</a>.`,
chooseAnExisting: 'Wybierz istniejące konto bankowe do opłacania wydatków lub dodaj nowe.',
},
changeOwner: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4df4c9f9..e06b5fdc 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6422,7 +6422,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
updateToUSD: 'Atualizar para USD',
updateWorkspaceCurrency: 'Atualizar moeda do espaço de trabalho',
workspaceCurrencyNotSupported: 'Moeda do workspace não suportada',
- yourWorkspace: `Seu workspace está configurado para uma moeda não compatível. Veja a <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">lista de moedas compatíveis</a>.`,
+ yourWorkspace: `Seu workspace está definido para uma moeda não compatível. Veja a <a href="${CONST.ENABLE_GLOBAL_REIMBURSEMENT_HELP_URL}">lista de moedas compatíveis</a>.`,
chooseAnExisting: 'Escolha uma conta bancária existente para pagar despesas ou adicione uma nova.',
},
changeOwner: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The "Workspace currency not supported" modal's "list of supported currencies" hyperlink was pointing to the "Connect a Business Bank Account" help article, which does not list supported currencies. This updates the link to point to the "Enable Global Reimbursement" article, which actually enumerates the supported currencies (USD, CAD, GBP, EUR, AUD).
Also renames the constant from
CONNECT_A_BUSINESS_BANK_ACCOUNT_HELP_URLtoENABLE_GLOBAL_REIMBURSEMENT_HELP_URLso the name matches the article it now points to, and updates all 10 language files to reference the renamed constant.Fixed Issues
$ #89516
PROPOSAL: #89516 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A - This change only updates a static URL constant.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari