migrate QuickBook Desktop#89579
Conversation
…OLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_PREFERRED_EXPORTER
…ECT and WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 601acc516c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const goBack = useCallback(() => { | ||
| Navigation.goBack(navigateBackTo ?? ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.getRoute(policyID)); | ||
| }, [policyID, navigateBackTo]); | ||
| Navigation.goBack(navigateBackTo ?? createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.path)); |
There was a problem hiding this comment.
Compute Auto Sync fallback from accounting root
When navigateBackTo is missing (for example, opening Auto Sync via a direct URL or after a page refresh), this fallback builds qbd-advanced from the current Auto Sync URL, yielding .../autosync/qbd-advanced instead of the parent Accounting path. DynamicQuickbooksDesktopAdvancedPage then strips only that suffix and returns to .../autosync, so the header back flow can bounce between Auto Sync and Advanced rather than leaving the flow. Use a stable parent base route for createDynamicRoute (or pass an explicit back target) instead of deriving from the active Auto Sync route.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I didn’t encounter this issue. It works as expected on my end.
|
@mananjadhav This PR is ready for review |
Explanation of Change
Fixed Issues
$ #83840
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_SELECT
Precondition: The workspace is connected to QuickBook Desktop.
WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED
Precondition: The workspace is connected to QuickBook Desktop.
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_DATE_SELECT
Precondition: The workspace is connected to QuickBook Desktop.
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_PREFERRED_EXPORTER
Precondition: The workspace is connected to QuickBook Desktop.
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_EXPORT_OUT_OF_POCKET_EXPENSES
Precondition: The workspace is connected to QuickBook Desktop.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-05.at.13.35.46.mov