Feature/bump pybotx version 0.73.4 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osovskiyalexandr
approved these changes
May 5, 2025
osovskiyalexandr
requested changes
May 6, 2025
.github/workflows/tests.yml
Outdated
| run: | | ||
| pip install copier==7.1.0 | ||
| pip install --upgrade pip # Ensure pip is updated | ||
| pip install --upgrade argcomplete>=1.9.4 # Update argcomplete first |
There was a problem hiding this comment.
Не совсем понятно, зачем вызывать --upgrade, потому что установкаpip install argcomplete>=1.9.4 сама обновит версию, если она у тебя отсатет.
.github/workflows/tests.yml
Outdated
| pip install pyyaml-include==1.4.1 | ||
| # hardcode pydantic version to avoid dependency conflict with copier | ||
| pip install pydantic==1.10.2 | ||
| pip install pyyaml-include |
There was a problem hiding this comment.
Аналогично, стоит фиксировать версию. Для поддержания совместимости между библиотеками.
vladimirgubarik
force-pushed
the
feature/bump-pybotx-version-0.73.4
branch
from
14b253b to
a71c9f1
Compare
vladimirgubarik
force-pushed
the
feature/bump-pybotx-version-0.73.4
branch
from
a71c9f1 to
bb5519e
Compare
osovskiyalexandr
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit:
Checklist
/helpcommand