This repository was archived by the owner on Dec 14, 2025. It is now read-only.
Initial implementation of API/user config controlled auto exposure and gain settings#43
Open
Initial implementation of API/user config controlled auto exposure and gain settings#43
Conversation
lorow
force-pushed
the
feature/autoexposure-api-control
branch
2 times, most recently
from
6a0f318 to
e562d92
Compare
lorow
changed the title
…fig - needs more testing
lorow
force-pushed
the
feature/autoexposure-api-control
branch
from
e562d92 to
ca70b88
Compare
ZanzyTHEbar
approved these changes
May 21, 2023
Collaborator
ZanzyTHEbar
left a comment
ZanzyTHEbar
left a comment
There was a problem hiding this comment.
Looks really good, everything sticks to the api and is well named. code looks good :)
- I tested the changes, haven't found an issue yet :) - so far it works well.
Member
Author
|
@ZanzyTHEbar I think I did, while the core functionality works as expected, changing the resolution causes the framebuffer to be a null pointer (or at least I think so, judging by the ESP_OK error which happens if we don't have the FB at the very beginning). I was in the process of inspecting the original examples buuuut decided to give a minute or two and focus on other projects to "reset" so to speak xD I'll be coming back to it today, if all goes according to plan |
lorow
added
the
back to the drawing board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to control the auto exposure, auto gain more easily, its levels, and the brightness of the video feed.
These settings can be changed in two ways:
ESP/ini/user_config.ini [autoexposure]settingsetCameracommand