Skip to content

chore: add opt-in large-tier benchmarks#112

Merged
FBumann merged 1 commit into
mainfrom
feat/large-benchmarks
Jul 23, 2026
Merged

chore: add opt-in large-tier benchmarks#112
FBumann merged 1 commit into
mainfrom
feat/large-benchmarks

Conversation

@FBumann

@FBumann FBumann commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Adds a large tier to the benchmark suite: production-sized cases that guard the memory-amplification regime the PR-sized cases can't reach, opt-in via a --large pytest flag (skipped by default, in CI too — they run locally before dependency bumps or performance work, per benchmarks/README.md).

Two cases, measured locally on tsam 3.4.2:

  • test_large_wide — 730 days × 256 columns (~34 MB input, full production config): 2.6 s, 415 MiB peak (the ~12× memory amplification is exactly what this guards)
  • test_large_scenarios — 365 days × 64 columns × 8 scenarios: 3.6 s, 106 MiB peak

Gating is a benchmarks/conftest.py --large option + large marker; without the flag the cases collect as skipped, so the CI workflow needs no change.

🤖 Generated with Claude Code

Two production-sized cases (730d x 256 cols at ~415 MiB peak, 365d x
64 cols x 8 scenarios) guard the memory-amplification regime that the
PR-sized cases cannot reach. Skipped by default including in CI — a
--large flag in benchmarks/conftest.py enables them for local runs
before dependency bumps or performance work.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@FBumann, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6dcafd8-dcb8-4aa5-8370-d3af36f31ec2

📥 Commits

Reviewing files that changed from the base of the PR and between 3fccdfc and ea7ddcf.

📒 Files selected for processing (3)
  • benchmarks/README.md
  • benchmarks/conftest.py
  • benchmarks/test_bench_aggregate.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/large-benchmarks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Benchmarks

Δ% vs base, one table sorted by biggest change first
(min walltime and memray peak). Peak memory is
deterministic — any delta there is real; walltime on GitHub
runners is noisy, so only large time deltas are meaningful.
The interactive plot is attached as the benchmark-plot artifact.

Full table

benchmarks/test_bench_aggregate.py

name metric base head
test_e2e_wide[medoid] time 0.5384s +4.3%
peak 113 MiB 0.0%
test_user_apply time 0.4398s +3.3%
peak 104 MiB 0.0%
test_config_extremes[append] time 0.056s +3.2%
peak 1.9 MiB 0.0%
test_wrapper_to_dataframe time 0.0004241s +1.8%
peak 8.55 MiB 0.0%
test_e2e_slices time 1.304s +1.7%
peak 14.3 MiB 0.0%
test_config_representation[medoid] time 0.05443s +1.6%
peak 1.9 MiB 0.0%
test_config_representation[dist_global] time 0.1398s +1.5%
peak 1.78 MiB 0.0%
test_user_disaggregate time 0.01305s +1.4%
peak 26.7 MiB 0.0%
test_e2e_wide[dist_global] time 2.02s +1.4%
peak 104 MiB 0.0%
test_config_extremes[replace] time 0.05611s +1.3%
peak 1.9 MiB 0.0%
test_config_representation[dist_cluster] time 0.05323s +1.3%
peak 1.78 MiB 0.0%
test_config_representation[mean] time 0.05183s +1.1%
peak 1.78 MiB 0.0%
test_e2e_full time 0.1618s +1.0%
peak 6.6 MiB 0.0%
test_config_representation[dist_global_minmax] time 0.1427s +1.0%
peak 1.78 MiB 0.0%
test_e2e_default time 0.07013s +0.5%
peak 7.11 MiB 0.0%
test_wrapper_concat_results time 0.02197s +0.1%
peak 8.72 MiB 0.0%
test_e2e_multidim time 0.2447s -4.6%
peak 26.7 MiB 0.0%
test_wrapper_result_conversion time 0.04036s -9.7%
peak 60.3 MiB 0.0%

@FBumann
FBumann merged commit 9f295fb into main Jul 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant