Skip to content

petsc4py stubs #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
schnellerhase wants to merge 9 commits into
base: main
Choose a base branch
from
+95 −85
Draft

petsc4py stubs #4095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3994466
Add mypy check to macos
schnellerhase Feb 17, 2026
b3c5367
[tmp] run against petsc@main
schnellerhase Feb 17, 2026
9d9c7cf
petsc4py: Fix type ignores la
schnellerhase Feb 17, 2026
e47d7fd
[WIP] petsc4py: Fix type ignores fem
schnellerhase Feb 17, 2026
9c613e0
add assert
schnellerhase Feb 17, 2026
457db72
run against branch
schnellerhase Feb 17, 2026
9968b29
fix createGhostWIthArray
schnellerhase Feb 17, 2026
ef2f517
Remove assert
schnellerhase Jul 21, 2026
459675e
simpler
schnellerhase Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
env:
PETSC_ARCH: arch-darwin-c-opt
PETSC_DIR: ${{ github.workspace }}/petsc
PETSC_VERSION: 3.25.3
# PETSC_VERSION: "3.25.3"
PETSC_VERSION: "petsc4py-stub-fixes"
PYTEST_ADDOPTS: "-W error"

steps:
Expand Down Expand Up @@ -64,7 +65,7 @@
run: |
export PATH="$(brew --prefix gfortran)/bin:$(brew --prefix bison)/bin:$PATH"
export PATH="$(brew --prefix make)/libexec/gnubin:$PATH"
git clone --depth 1 --branch v${PETSC_VERSION} https://gitlab.com/petsc/petsc.git petsc
git clone --depth 1 --branch ${PETSC_VERSION} https://gitlab.com/paul.kuehner/petsc.git petsc
cd petsc
./configure \
--with-64-bit-indices=no \
Expand Down Expand Up @@ -131,6 +132,14 @@
python -m scikit_build_core.build requires | python -c "import sys, json; print(' '.join(json.load(sys.stdin)))" | xargs pip install
pip install --check-build-dependencies --no-build-isolation --config-settings=cmake.build-type="Developer" './[test]'

- name: Run mypy
working-directory: python
run: |
pip install mypy types-cffi scipy-stubs

Check warning on line 138 in .github/workflows/macos.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--only-binary :all:" can lead to the execution of setup scripts. Make sure it is safe here. 


See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ9_snt9eOuKz1Fr22dC&open=AZ9_snt9eOuKz1Fr22dC&pullRequest=4095

Check warning on line 138 in .github/workflows/macos.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZ9_snt9eOuKz1Fr22dD&open=AZ9_snt9eOuKz1Fr22dD&pullRequest=4095

Check warning

Code scanning / SonarCloud

Python package manager scripts should not be executed during installation Medium

Omitting "--only-binary :all:" can lead to the execution of setup scripts. Make sure it is safe here. See more on SonarQube Cloud

Check warning

Code scanning / SonarCloud

Python dependencies should be locked to verified versions Medium

Using dependencies without locking resolved versions is security-sensitive. See more on SonarQube Cloud
mypy -p dolfinx
mypy test
mypy demo

- name: Basic test
run: |
mpiexec -np 1 python -c "from mpi4py import MPI; import dolfinx; assert dolfinx.has_parmetis and dolfinx.has_petsc and dolfinx.has_superlu_dist and dolfinx.has_ptscotch"
Expand Down
Loading
Loading