Fixes issue #XX - Fix CRLF line endings in shell scripts on Windows/WSL#95
Open
RukadeAkshay01 wants to merge 1 commit intoFOSSEE:masterfrom
Open
Fixes issue #XX - Fix CRLF line endings in shell scripts on Windows/WSL#95RukadeAkshay01 wants to merge 1 commit intoFOSSEE:masterfrom
RukadeAkshay01 wants to merge 1 commit intoFOSSEE:masterfrom
Conversation
Shell scripts (start_server.sh and sock_pkg_create.sh) generated by model_generation.py had Windows line endings (CRLF) when run on Windows or WSL. This broke bash parameter parsing, causing the port and IP parameters to not be passed correctly to sock_pkg_create.sh, resulting in VHDL simulations failing with 'sock_pkg has not been analyzed' errors. Fixed by adding newline='\n' parameter to open() calls when creating shell scripts, forcing Unix line endings (LF) on all platforms. Author: Akshay Rukade <akshayrukade01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed CRLF line ending issue in model_generation.py that caused VHDL simulations to fail on Windows/WSL.
Changes
newline='\n'parameter toopen()calls when creating start_server.sh andsock_pkg_create.shTesting
Tested on Windows 11 with WSL Ubuntu 24.04. VHDL simulations (full_adder) now work correctly.
Related Issue
Fixes #XX
Author: Akshay Rukade akshayrukade01@gmail.com