Open
Conversation
Contributor
adityacp
commented
Apr 8, 2021
- Add a separate URL in code server to get file urls and download it in the student directory.
- Add a celery task to send all question files at once to the code server at the start of the quiz instead of sending the files during evaluation.
- Change assignment file urls instead of absolute path to the code server for evaluation.
- Fix issue while deleting the Lesson file.
|
Hello @adityacp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-04-26 05:20:53 UTC |
- Fix R and Python evaluation tests - Add return to the celery task to store the task result in the database
e9b2116 to
4c30f46
Compare
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 76.69% 76.30% -0.39%
==========================================
Files 53 53
Lines 7684 7761 +77
Branches 1166 1177 +11
==========================================
+ Hits 5893 5922 +29
- Misses 1408 1453 +45
- Partials 383 386 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.