test: add Read the Docs golden fixture - #62
Merged
FROWNINGdev merged 1 commit intoJul 30, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds Read the Docs as a sixth vendored Django golden fixture, commits its parsed model snapshot, updates regression coverage, and records the project’s source attribution and fetch metadata. ChangesRead the Docs golden fixture
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant FetchScript
participant GitHub
participant ScanWorkspace
participant SnapshotTests
FetchScript->>GitHub: Fetch readthedocs/projects/models.py
GitHub-->>FetchScript: Return vendored source
SnapshotTests->>ScanWorkspace: Scan Read the Docs fixture
ScanWorkspace-->>SnapshotTests: Return parsed model schema
SnapshotTests->>SnapshotTests: Compare with readthedocs.snapshot.json
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Read the Docs as the sixth real-world golden fixture, including its generated snapshot, reproducible fetch metadata, and MIT attribution. This expands coverage to 16 additional Django models and 142 fields while preserving byte-stable snapshots and the existing performance gate.
Type of change
Test plan
cd cli && python -m pytest -q tests/test_golden_fixtures.py tests/test_golden_snapshots.py— 14 passed in 0.20scd cli && python -m pytest -q— 448 passed, 2 skipped, 41 subtests passedcd cli && python -m ruff check django_orm_lens tests— passedcd cli && python -m mypy django_orm_lens— passednpm test— build succeeded, 109 passedreadthedocs/projects/models.pyat blobcf1e913d78d4751c86defc837ef80bf872b96d4eChecklist
cd cli && pytest -qfor Python,npm testfor TypeScript) and it is green## [Unreleased](not user-facing; no entry required)mcp_server.pyand the relevant tests intest_mcp_server.py(not applicable)## Summaryabove and suggested a migration path (not applicable)Related issues / discussions
Closes #51
Summary by CodeRabbit
New Coverage
Documentation
Tests